There's a larger discussion about moving some of the repos out of
the GlassFish project. They got dumped in there to begin with just
to avoid having too many fine grained projects. See the discussion
in glasssfish-dev, or one of the glassfish issues (I forget where
exactly).
arjan tijms wrote on 2/18/20 8:47 AM:
Hi,
I did have some thoughts too about "glassfish" vs "ee4j".
Currently almost all implementations are "glassfish"
(Soteria, Mojarra, etc). Should we move those all to "ee4j",
or, could we instead just as well rename the ee4j repo to
"glassfish" once all the specs/apis have been moved to
the jakartaee org?
Just some thought...
Kind regards,
Arjan Tijms
Thanks, Arjan!
I'm
thinking that
this plugin should probably move to the org.eclipse.ee4jgroupId, don't
you think? And, then possibly rename this repo to
remove the "glassfish-" prefix? Just another step in the
direction of separating the Specs from the
Implementation... Not
convinced it's an immediate requirement for Jakarta EE 9,
but I could be
swayed... Thoughts?
---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail: sutter@xxxxxxxxxx Twitter:
@kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter
From:
arjan
tijms <arjan.tijms@xxxxxxxxx>
To:
jakartaee-platform
developer discussions <jakartaee-platform-dev@xxxxxxxxxxx>
Date:
02/18/2020
08:46
Subject:
[EXTERNAL]
Re: [jakartaee-platform-dev] About to release a new version
of
spec-version-maven-plugin
Sent
by: jakartaee-platform-dev-bounces@xxxxxxxxxxx
Hi Kevin,
Yes, it's that plug-in and it
essentially
boils down to this commit: https://github.com/eclipse-ee4j/glassfish-spec-version-maven-plugin/commit/8713dc7cdef6306747bb4a3d20191c0bb0b54026
There I added support for the RCx
qualifier,
and threat it just like -SNAPSHOT as a transparent qualifier
basically.
I briefly looked at some other
API projects,
such as Concurrency, and they essentially just disabled the
plug-in
in order to stage. See e.g.
https://github.com/eclipse-ee4j/concurrency-api/commit/a76aa6795a9472be81c8f5fbf0dc91d157b6ede5
I think all API projects should
indeed
use the plug-in. The plug-in essentially sets a couple of
properties,
which the POM then feeds back into the Maven Bundle plug-in.
Of course
you can set these properties manually as well (and some
projects have
done this, like I think Servlet), but for consistency and
validation it's
probably better to use that spec plug-in.
Hope this helps!
Kind regards,
Arjan Tijms
On Tue, Feb 18, 2020 at 3:39 PM
Kevin
Sutter <sutter@xxxxxxxxxx>
wrote:
Hi Arjan,
Can you clarify which specific plugin you are referring to?
Is it
theglassfish-spec-version-maven-plugin?
Or, is there a generic, non-glassfish version that you are
modifying?
And, I'm curious why only a handful of APIs are having this
issue.
Is this plugin not used by all of the Spec/API projects?
Should
it be used? Thanks for the education.
---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail: sutter@xxxxxxxxxx Twitter:
@kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)
LinkedIn: https://www.linkedin.com/in/kevinwsutter
From: Tom
Jenkinson <tom.jenkinson@xxxxxxxxxx>
To: jakartaee-platform
developer discussions <jakartaee-platform-dev@xxxxxxxxxxx>
Cc: glassfish
developer discussions <glassfish-dev@xxxxxxxxxxx>
Date: 02/18/2020
04:10
Subject: [EXTERNAL]
Re: [jakartaee-platform-dev] About to release a new version
of
spec-version-maven-plugin
Sent by: jakartaee-platform-dev-bounces@xxxxxxxxxxx
Hi Arjan,
I think I have encountered the same issue but when trying to
create an
"-M1" version on Jakarta Transactions. Would a similar
change
be possible for that type of qualifier?
Thanks,
Tom
On Wed, 5 Feb 2020 at 21:33, arjan tijms <arjan.tijms@xxxxxxxxx>
wrote:
Hi,
Several projects had an issue with not being able to build a
maven project
using the spec-version-maven-plugin when having a -RCx
qualifier.
E.g.
<groupId>jakarta.security.auth.message</groupId>
<artifactId>jakarta.security.auth.message-api</artifactId>
<version>2.0.0-RC1</version>
I've updated the plug-in to threat RC1 essentially the same
as a -SNAPSHOT
qualifier, meaning it's stripped-off for the sake of
the spec-version-maven-plugin.
This works with the regular final mode (the default), which
is the same
as for the -SNAPSHOT qualifier.
The result is a MANIFEST.MF with the relevant version set
(in this case)
to 2.0.0.
unzip -p
target/jakarta.security.auth.message-api-2.0.0-RC1.jar
META-INF/MANIFEST.MF
Manifest-Version: 1.0
Created-By: Apache Maven Bundle Plugin
Built-By: arjan.tijms
Build-Jdk: 13.0.1
Automatic-Module-Name: java.security.auth.message
Bnd-LastModified: 1580938099883
Bundle-Description: Jakarta Authentication 2.0 Specification
Bundle-DocURL: https://github.com/eclipse-ee4j/authentication
Bundle-License: http://www.eclipse.org/legal/epl-2.0,
https://www.gnu.or
g/software/classpath/license.html
Bundle-ManifestVersion: 2
Bundle-Name: Jakarta Authentication
Bundle-SymbolicName: jakarta.security.auth.message-api
Bundle-Vendor: Jakarta Authentication
Bundle-Version: 2.0.0
Export-Package:
jakarta.security.auth.message;uses:="javax.security.auth
,javax.security.auth.login";version="2.0.0",jakarta.security.auth.messa
ge.config;uses:="jakarta.security.auth.message,javax.security.auth,java
x.security.auth.callback";version="2.0.0",jakarta.security.auth.message
.module;uses:="jakarta.security.auth.message,javax.security.auth.callba
ck";version="2.0.0",jakarta.security.auth.message.callback;uses:="javax
.crypto,javax.security.auth,javax.security.auth.callback,javax.security
.auth.x500";version="2.0.0"
Extension-Name: jakarta.security.auth.message
Implementation-Vendor: Jakarta Authentication
Implementation-Vendor-Id: org.glassfish
Implementation-Version: 2.0.0
Import-Package:
jakarta.security.auth.message,javax.crypto,javax.securit
y.auth,javax.security.auth.callback,javax.security.auth.login,javax.sec
urity.auth.x500
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
Specification-Vendor: Oracle Corporation
Specification-Version: 2.0
Tool: Bnd-4.2.0.201903051501
If this is what is everyone likes to see I can release
spec-version-maven-plugin
as version 2.1.
Kind regards,
Arjan Tijms
_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password,
or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password,
or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev
_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password,
or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password,
or unsubscribe
from this list, visit
https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev
_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or
unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev
_______________________________________________
jakartaee-platform-dev mailing list
jakartaee-platform-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/jakartaee-platform-dev__;!!GqivPVa7Brio!Iqm0tgAsiDNJ7dCwm2cNmd_olwXGP2k0jwbL_zCByyNovriRPdV3j7CBNRzE9X1CVQ$
|
