Re: [jakartabatch-dev] whitespace / formatting

[Cheng Fang <cfang@xxxxxxxxxx>]

It's always a good idea to separate content change from formatting changes in PR. Also good to add checkstyle plugin that is configured with reasonable policy to project setup to enforce it. 

On Tue, Mar 31, 2020 at 11:00 AM Scott Kurz <skurz@xxxxxxxxxx> wrote:

For each of the API/TCK projects, I don't think we ever paid too much attention to consistent formatting. I'd have to check what our EOL situation is as well.

If anyone wants to be the first to propose a format and possibly enforcement (e.g. checkstyle) be my guest.

Otherwise, I'm going to try to just reject PRs that mix reformatting with content changes.

Though for something like this:
https://github.com/thadumi/batch-tck/commit/c9b29b42d68eeb4c12cc264897079be926493737
I think I'd just break that into two commits: one removing trailing whitespace for all Java parts and then the content.

Tried to note this here: https://github.com/eclipse-ee4j/batch-api/wiki/Ways-To-Contribute

But if you're interested, please feel free to propose/implement.
------------------------------------------------------
Scott Kurz
WebSphere Batch and Developer Experience
skurz@xxxxxxxxxx
--------------------------------------------------------

_______________________________________________
jakartabatch-dev mailing list
jakartabatch-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/jakartabatch-dev