Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [jakarta.ee-spec] [cdi-dev] BALLOT: Approval to Release Jakarta CDI 3.0
Hmm, strange as I don't see anything amiss in the commit history. Not sure what happened, but thanks for finding the issue David and the update Ivar. I have merged the changes and will update the PR when I have done a new release.

On Wed, Aug 26, 2020 at 5:01 AM Ivar Grimstad <ivar.grimstad@xxxxxxxxxxxxxxxxxxxxxx> wrote:
Hi,

I just did a PR that fixes the issues reported above, https://github.com/eclipse-ee4j/cdi/pull/444

After submitting this PR, I started wondering why we didn't catch the missing Java EE -> Jakarta EE replacements in Jakarta EE 8.
And after a quick check of the CDI 2.0 PDF, https://jakarta.ee/specifications/cdi/2.0/cdi-spec-2.0.pdf, I discovered that it was done there as expected.
Is there missing merge from the 2.0 release into master that caused the changes done then to disappear? 
I'm cross-posting this to the cdi-dev mailing list as well.

Ivar


On Wed, Aug 26, 2020 at 5:06 AM David Blevins <dblevins@xxxxxxxxxxxxx> wrote:
Sorry, have to update that vote to -1 for the following reasons:

- There are still 239 references to "Java EE" in the specification (not the show stopper)

- There are invalid javax references in the specification (show stopper):
   - javax.faces.context.FacesContext
   - javax.servlet.http.HttpServletRequest,
   - javax.servlet.http.HttpSession
   - javax.servlet.ServletContext
   - javax.ejb.embeddable.modules

- There is one invalid javax reference in the Javadoc (show stopper):
   - javax.annotation.ManagedBean

Though there are enough votes to pass the spec, we recommend a re-roll as there is time in the schedule and we're not far in the waves.

Back to the top