[iot-pmc] [CQ 20688] Android Project Headers for UPM MMC35240 Library

[emo-ip-team@xxxxxxxxxxx]

http://dev.eclipse.org/ipzilla/show_bug.cgi?id=20688





--- Comment #14 from Tudor Panu <mihai.tudor.panu@xxxxxxxxx>  2019-09-25 15:35:22 ---
(In reply to comment #13)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > (In reply to comment #8)
> > > > Hi Kai, Achim,
> > > > 
> > > > These headers are part of the UPM MMC35240 sensor driver which is currently one
> > > > of the many modules in the UPM project. So yes, our Github code base
> > > > redistributes these 3 utility headers, as offered under the Apache 2.0 license
> > > > from the Android project.
> > > > 
> > > > We do not link to the Android project.
> > > > 
> > > 
> > > So, does your initial contribution for UPM already contain these files?
> > 
> > Yes it does. I have also attached a version of the project that does not
> > include the mmc35240 library.
> > 
> 
> I am not sure if I fully understand how the build works but I assume that you
> dynamically link to the mmc35240 library, is that correct? If so, then what
> happens when, during runtime, the mmc35240 library is not on the library path? 
> Will UPM still work or will it crash immediately (or not start up at all)?
> If the former is the case then it looks like mmc35240 is a works-with
> dependency and since you already re-distribute the header files in UPM you will
> only need a works-with CQ for mmc35240. However, if the latter is the case then
> it is a pre-req dependency and you will need to add the full source code of the
> mcc35240 library to this CQ (not just the headers).
> Or is there no full source code, i.e. the headers already also contain the
> implementation?

Actually this would not be a works-with case. The MMC35240 library is part of
the UPM project and builds with the project.

The Apache 2.0 headers including implementation are redistributed with it and
required for a successful build of the MMC35240 library:

Directory: upm\src\mmc35240

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
-a----        9/28/2018  10:38 PM            227 CMakeLists.txt
-a----        9/28/2018  10:38 PM          12064 mat.h
-a----        8/19/2019   9:17 PM          24019 mmc35240.cxx
-a----        8/19/2019   9:17 PM           5969 mmc35240.hpp
-a----        9/28/2018  10:38 PM           2021 mmc35240.json
-a----        9/28/2018  10:38 PM           3524 traits.h
-a----        9/28/2018  10:38 PM          12664 vec.h

The entire MMC35240 library is now also attached to this CQ. Relative path to
the UPM project also shown.

Thanks,
Tudor


> > > > You can build the UPM project for Android OS but that's an entirely different
> > > > story :)
> > > > 
> > > > Hope this clarifies things.
> > > > 
> > > > Thanks,
> > > > Tudor
> > > > 
> > > 
> > 
> 


-- 
Configure CQmail: http://dev.eclipse.org/ipzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the CQ.