[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[iot-pmc] [CQ 16191] IOT HIP Initial Contribution
|
http://dev.eclipse.org/ipzilla/show_bug.cgi?id=16191
Jens Reimann <jreimann@xxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jreimann@xxxxxxxxxx
--- Comment #4 from Jens Reimann <jreimann@xxxxxxxxxx> 2018-04-30 07:40:19 ---
Hi Mark,
I just took a brief look into your initial contribution. In general this looks
fine, but there are a few things I would like you to take a look at.
This archive should only contain code you authored, so no third party stuff.
However I do see "IC/Commander/src/favicon.ico", which looks like the Angular
icon. Maybe you could take another round on the archive and remove all files
which are not authored by yourself or any author your listed.
Several files seem to miss a license header, e.g.
"/IC/Commander/src/app/control/control.component.spec.ts". I also think you are
missing a "notice" file.
As you do have several readme it would be appropriate to apply the proper
trademark, like in "/IC/protocol specification/README.md" in the headline ->
"Eclipse HIP™ - the Hierarchical IoT Protocol". Not every occurrence, but only
the first prominent one. Maybe this helps [1].
It also looks like you have quite a big set of dependencies. I think it would
make sense to start working on those as well. As a new project you are by
default a Type_A project, which only does a license compatibility check. I
think for JavaScript you can do a composite CQ of all dependencies in a single
package. Howver, I am not sure about that myself. So I think it would be best
prepare a full list of dependencies (including transient dependencies) and get
in contact with Sharon of Eclipse and get some guidance. If you like I can help
you there.
[1] https://www.eclipse.org/legal/logo_guidelines.php
--
Configure CQmail: http://dev.eclipse.org/ipzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the CQ.
