[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[iot-pmc] [CQ 15745] Thingweb Directory
|
http://dev.eclipse.org/ipzilla/show_bug.cgi?id=15745
Jens Reimann <jreimann@xxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jreimann@xxxxxxxxxx
--- Comment #6 from Jens Reimann <jreimann@xxxxxxxxxx> 2018-03-19 08:33:21 ---
I was just browsing through the source code. So I didn't fully check it.
What I did find is that the package name still is "de.thingweb.*", which should
be "org.eclipse.<projectname>".
I also found some package names "com.onto", if that is code which you did not
author, then you would need to create another CQ for an external dependency. I
also don't see any indication of who authored the code you uploaded. I would
assume a link to the GitHub repository as you did is not enough, as this covers
the full repository, not the code attached to this CQ.
The license in the file is "MIT LICENSE", which, most likely, should be EPLv1
or EPLv2, unless you project has an exception, which I didn't check.
The grade wrapper JAR probably also is not code which you authored and thus
should be removed from this CQ.
I also can't find any license header in this source files.
I know bringing code to Eclipse can be a bit tough in the beginning, and I am
happy to help. If you have any questions I would suggest to get in contact with
your mentors and ask them. If that fails, please let me know and I can help of
course.
--
Configure CQmail: http://dev.eclipse.org/ipzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the CQ.
