[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[iot-pmc] [CQ 15322] Cyclone DDS step 1
|
http://dev.eclipse.org/ipzilla/show_bug.cgi?id=15322
Jens Reimann <jreimann@xxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jreimann@xxxxxxxxxx
--- Comment #6 from Jens Reimann <jreimann@xxxxxxxxxx> 2018-01-24 09:19:04 ---
This is indeed a lot of code. I guess this might take a while.
I noticed the "external" folder, which seems to contain external code. However
this code shouldn't go into this CQ. Each external module should have its own
CQ. And I think for "snappy-c" you already did this.
I also saw that you use Matlab to some degree. I am not sure Matlab is an
approved dependency. Maybe Sharon knows something about that.
The "docs" folder also seems contain some generated content. If that is the
case, then it should be removed, as only source content should be part of this
CQ. Meaning, everything which is generated as part of the build process should
be removed from the source archive. Of course the CSS files, for example, are
probably authored and not generated. So they should be part of the CQ.
--
Configure CQmail: http://dev.eclipse.org/ipzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the CQ.
