Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [iot-pmc] JavaScript CQs

Hi Kai,

_javascript_ libs indeed often aren’t easy… I agree that in general the original, pre-processed source should be added to the CQ as this is the code that is relevant wrt copyright.

Pretty often it is not easy to figure out what part of a repo actually IS the original source - so the solution of Axel to attach the built source instead might be an acceptible pragmatic approach (certainly only because this built source is still human readable and not a minified js version).

We actually recently had a similar issue (see here: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=13827#c8): The js build system is so opaque
that we have no clue what sources are exactly used for building the module that we are effectively using in the end. So our only chance was to request an IP review for the whole repo (minus tests&docs of course).

I am not sure if Axel’s solution is acceptable by the IP team - I guess only they will be able to give a definitive answer here.

Just my two cents,
Kai

On 29. Nov 2017, at 15:33, Hudalla Kai (INST/ECS4) <kai.hudalla@xxxxxxxxxxxx> wrote:

Hi PMC

as you may have noticed, the unide project has issued a lot of CQs for _javascript_ libs. I would like to draw your attention to [1] because I ran into a situation I do not really know how to proceed with because I am not a _javascript_ developer and have too little insight into the technology.

My understanding, though, is that the "module" source is comparable to the Java source code files typically found in the source code repository, whereas the "built" source (as the name implies) is some form of distributable artifact that people include in their _javascript_ code. In that it seems to be similar to the Java JAR artifacts containing the (compiled) class files.

Which code should be contained in the attached source archive? If my understanding is correct, then I believe it should be the "module" source code, shouldn't it?

[1] http://dev.eclipse.org/ipzilla/show_bug.cgi?id=14878

--

Mit freundlichen Grüßen / Best regards

Kai Hudalla
Chief Software Architect

Bosch Software Innovations GmbH
Ullsteinstraße 128
12109 Berlin
GERMANY
www.bosch-si.com

Registered Office: Berlin, Registration Court: Amtsgericht Charlottenburg; HRB 148411 B
Chairman of the Supervisory Board: Dr.-Ing. Thorsten Lücke; Managing Directors: Dr.-Ing. Rainer Kallenbach, Michael Hahn

_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc


Back to the top