Re: [iot-pmc] Discussion/Vote for findbugs annotations – Eclipse Milo

[Jens Reimann <jreimann@xxxxxxxxxx>]

No the discussion is just started.

The milo release should have been this week (7th of December). However the findbugs topic has taken longer than expected.

Now in order to get this release out as quick as possible, I am trying to go both ways. Either we can agree on having JSR305 annotations as works-with dependency, or Milo needs to switch to something else.

However switching to jetbrains annotations will trigger a complete new 3rd party dependency CQ and may take way longer.

I hope this explains the current situation.

Thanks for you quick response!

Jens

On Mon, Dec 5, 2016 at 10:40 AM, Kai Kreuzer <kai@xxxxxxxxxxx> wrote:

Is the discussion already ended? The last comment from Kevin (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11244#c16) seems to indicate that he has just switched to jetbrains annotations instead of JSR305?

But in general I agree that this can be a compile-time dependency, so here’s my +1 for a compile/build/test-only works-with dependency.

Regards,

Kai

On 5 Dec 2016, at 10:33, Jens Reimann <jreimann@xxxxxxxxxx> wrote:

Now technically it is true that the JSR 305 annotations are flagged a "runtime annotations" and a reference ends up in the final binary class files.

However I still think that there is no logic applied to that and it is pretty sure that Milo will run perfectly without those annotations.

So +1 from me for works-with

On Mon, Dec 5, 2016 at 10:31 AM, Jens Reimann <jreimann@xxxxxxxxxx> wrote:

Hi PMC,

Eclipse Milo would like to use the JSR305 annotations coming from the findbugs project. [1]

Since those annotations are only used during the compile time (for automated error checking) Milo would like to got with a works-with dependency.

Please discuss/vote …

Cheers

Jens

[1] https://dev.eclipse.org/ipzilla/show_bug.cgi?id=11244

-- 

Jens Reimann
Senior Software Engineer / EMEA ENG Middleware
Werner-von-Siemens-Ring 14
85630 Grasbrunn
Germany
phone: +49 89 2050 71286
_____________________________________________________________________________

Red Hat GmbH, www.de.redhat.com,
Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill

-- 

Jens Reimann
Senior Software Engineer / EMEA ENG Middleware
Werner-von-Siemens-Ring 14
85630 Grasbrunn
Germany
phone: +49 89 2050 71286
_____________________________________________________________________________

Red Hat GmbH, www.de.redhat.com,
Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill

_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc

_______________________________________________
iot-pmc mailing list
iot-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/iot-pmc

--

Jens Reimann
Senior Software Engineer / EMEA ENG Middleware
Werner-von-Siemens-Ring 14
85630 Grasbrunn
Germany
phone: +49 89 2050 71286
_____________________________________________________________________________

Red Hat GmbH, www.de.redhat.com,
Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill