Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [incquery-dev] Jenkins build is still unstable: EMF-IncQuery Testing - School Tests #780

Hi

If I remember correctly these things were used in a try-catch-finally, where the finally branch always rolled back the transaction after the test has completed.
I will also take a closer look, it was 5 months ago.

Cheers,
Tamas


2013.10.31. 18:02 keltezéssel, Ujhelyi Zoltán írta:
Hi,

these test failures were brough forth by a migrating the builds to a different server instance. After evaluating it in our Eclipse instance, we have found with Ábel that this issue comes only forth if all tests of the incquery.runtime.base.tests projects are executed, but works well if they are evaluated isolatedly.

After some experimenting with git bisect I have found an old commit (https://github.com/ujhelyiz/EMF-IncQuery-Examples/commit/997f93fe8411ec735b3a3216b947e7f75858a570) that introduces such an issue first: it changes the test environment to re-use the same model instance between different test cases.

This means, not the failing tests are faulty here but some other test that changes the models, but fails to restore its model. We will need to track that down, but I have to leave for now.

On the other hand, I am asking whether this approach was a good idea. My main problem with this kind of reuse is that a single faulty test can break other tests in a non-deterministic ways. The original approach that re-built the model for each test case is much more safe here.

Cheers,
Zoli
-- Zoltán Ujhelyi
https://www.inf.mit.bme.hu/en/members/ujhelyiz

Fault Tolerant Systems Research Group
Budapest University of Technology and Economics

On 2013.10.31., at 16:11, Jenkins Build  <build@xxxxxxxxxxxxxx> wrote:

See <https://build.inf.mit.bme.hu/jenkins/job/EMF-IncQuery-Tests-School/changes>
_______________________________________________
incquery-dev mailing list
incquery-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/incquery-dev

--
Tamas Szabo
Software engineer

Tel.:   +49 711 342 191 0
Fax.:   +49 711 342 191 29
Mobil:  +49 171 565 416 9
Web:    www.itemis.de
Mail:   tamas.szabo@xxxxxxxxx
Skype:  szabta89

itemis AG
Niederlassung Süd
Meitnerstr. 10
70563 Stuttgart

Rechtlicher Hinweis:
Registergericht: Amtsgericht Dortmund HRB 20621 | Sitz der Gesellschaft:
Lünen
Vorstand: Jens Wagener (Vorsitzender) | Wolfgang Neuhaus | Dr. Georg
Pietrek | Jens Trompeter | Sebastian Neus
Aufsichtsrat: Prof. Dr. Burkhard Igel (Vorsitzender) | Stephan Grollmann
| Michael Neuhaus



Back to the top