Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ice-dev] [ice-build] [Hudson] Build failed in Hudson: ice-next #734

Looks like there was a problem with the signing server. It seems to be back again now.

Greg

> On Aug 5, 2016, at 9:22 AM, Billings, Jay Jay <billingsjj@xxxxxxxx> wrote:
> 
> Greg,
> 
> Any thoughts on this? It looks like the Mac OS/X signing failed again.
> 
> Jay
> 
> Jay Jay Billings
> Oak Ridge National Laboratory
> Twitter Handle: @jayjaybillings
> ________________________________________
> From: ice-build-bounces@xxxxxxxxxxx <ice-build-bounces@xxxxxxxxxxx> on behalf of hudsonbuild@xxxxxxxxxxx <hudsonbuild@xxxxxxxxxxx>
> Sent: Thursday, August 04, 2016 6:11 PM
> To: ice-build@xxxxxxxxxxx
> Subject: [ice-build] [Hudson] Build failed in Hudson: ice-next #734
> 
> See <http://hudson.eclipse.org/ice/job/ice-next/734/>
> 
> ------------------------------------------
> [...truncated 4660 lines...]
> [INFO] --- repository-utils:0.23.3:generate-repository-facade (generate-facade) @ org.eclipse.ice.repository ---
> [INFO] Building zip: /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.repository/target/org.eclipse.ice.repository-2.1.8-SNAPSHOT.zip
> [INFO]
> [INFO] --- maven-antrun-plugin:1.3:run (deploy) @ org.eclipse.ice.repository ---
> [INFO] Executing tasks
>   [unzip] Expanding: /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.repository/target/org.eclipse.ice.repository-2.1.8-SNAPSHOT.zip into /home/data/httpd/download.eclipse.org/ice/builds/next
>    [copy] Copying 1 file to /home/data/httpd/download.eclipse.org/ice/builds/next
> [INFO] Executed tasks
> [INFO]
> [INFO] ------------------------------------------------------------------------
> [INFO] Building ICE Product 2.1.8-SNAPSHOT
> [INFO] ------------------------------------------------------------------------
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.eclipse.ice.product ---
> [INFO] Deleting /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target
> [INFO]
> [INFO] --- tycho-packaging-plugin:0.24.0:build-qualifier-aggregator (default-build-qualifier-aggregator) @ org.eclipse.ice.product ---
> [INFO] The project's OSGi version is 2.1.8.201608042115
> [INFO]
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean-1) @ org.eclipse.ice.product ---
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ org.eclipse.ice.product ---
> [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
> [INFO] skip non existing resourceDirectory /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/src/main/resources
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:copy-resources (process-about.mappings) @ org.eclipse.ice.product ---
> [WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
> [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
> [INFO] Copying 0 resource
> [INFO]
> [INFO] --- target-platform-configuration:0.24.0:target-platform (default-target-platform) @ org.eclipse.ice.product ---
> [INFO]
> [INFO] --- tycho-p2-publisher-plugin:0.24.0:publish-products (default-publish-products) @ org.eclipse.ice.product ---
> [INFO]
> [INFO] --- tycho-p2-publisher-plugin:0.24.0:publish-categories (default-publish-categories) @ org.eclipse.ice.product ---
> [INFO]
> [INFO] --- tycho-p2-publisher-plugin:0.24.0:attach-artifacts (default-attach-artifacts) @ org.eclipse.ice.product ---
> [INFO]
> [INFO] --- tycho-p2-repository-plugin:0.24.0:assemble-repository (default-assemble-repository) @ org.eclipse.ice.product ---
> [INFO]
> [INFO] --- tycho-p2-repository-plugin:0.24.0:archive-repository (default-archive-repository) @ org.eclipse.ice.product ---
> [INFO] Building zip: /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/org.eclipse.ice.product-2.1.8-SNAPSHOT.zip
> [INFO]
> [INFO] --- tycho-pack200a-plugin:0.24.0:normalize (pack200-normalize) @ org.eclipse.ice.product ---
> [INFO]
> [INFO] --- eclipse-jarsigner-plugin:1.1.3:sign (sign) @ org.eclipse.ice.product ---
> [INFO]
> [INFO] --- tycho-pack200b-plugin:0.24.0:pack (pack200-pack) @ org.eclipse.ice.product ---
> [INFO]
> [INFO] --- tycho-p2-plugin:0.24.0:p2-metadata (p2-metadata) @ org.eclipse.ice.product ---
> [INFO]
> [INFO] --- tycho-p2-director-plugin:0.24.0:materialize-products (materialize-products) @ org.eclipse.ice.product ---
> [INFO] Installing product ice.runtime.product for environment linux/gtk/x86 to /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/linux/gtk/x86
> Installing ice.runtime.product 2.1.8.201608042115.
> Operation completed in 70922 ms.
> [INFO] Installing product ice.runtime.product for environment linux/gtk/x86_64 to /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/linux/gtk/x86_64
> Installing ice.runtime.product 2.1.8.201608042115.
> Operation completed in 79901 ms.
> [INFO] Installing product ice.runtime.product for environment win32/win32/x86 to /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/win32/win32/x86
> Installing ice.runtime.product 2.1.8.201608042115.
> Operation completed in 81552 ms.
> [INFO] Installing product ice.runtime.product for environment win32/win32/x86_64 to /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/win32/win32/x86_64
> Installing ice.runtime.product 2.1.8.201608042115.
> Operation completed in 72918 ms.
> [INFO] Installing product ice.runtime.product for environment macosx/cocoa/x86_64 to /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/macosx/cocoa/x86_64/ICE.app
> Installing ice.runtime.product 2.1.8.201608042115.
> Operation completed in 75228 ms.
> [INFO] Installing product ice.sdk.product for environment linux/gtk/x86 to /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.sdk.product/linux/gtk/x86
> Installing ice.sdk.product 2.1.8.201608042115.
> Operation completed in 66490 ms.
> [INFO] Installing product ice.sdk.product for environment linux/gtk/x86_64 to /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.sdk.product/linux/gtk/x86_64
> Installing ice.sdk.product 2.1.8.201608042115.
> Operation completed in 72823 ms.
> [INFO] Installing product ice.sdk.product for environment win32/win32/x86 to /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.sdk.product/win32/win32/x86
> Installing ice.sdk.product 2.1.8.201608042115.
> Operation completed in 66775 ms.
> [INFO] Installing product ice.sdk.product for environment win32/win32/x86_64 to /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.sdk.product/win32/win32/x86_64
> Installing ice.sdk.product 2.1.8.201608042115.
> Operation completed in 64801 ms.
> [INFO] Installing product ice.sdk.product for environment macosx/cocoa/x86_64 to /jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.sdk.product/macosx/cocoa/x86_64/ICE_SDK.app
> Installing ice.sdk.product 2.1.8.201608042115.
> Operation completed in 57844 ms.
> [INFO]
> [INFO] --- eclipse-winsigner-plugin:1.1.3:sign (default) @ org.eclipse.ice.product ---
> [INFO] [Thu Aug 04 17:47:54 EDT 2016] Signing Windows executable '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.sdk.product/win32/win32/x86/eclipsec.exe'
> [INFO] [Thu Aug 04 17:47:54 EDT 2016] Signing Windows executable '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.sdk.product/win32/win32/x86_64/eclipsec.exe'
> [INFO] [Thu Aug 04 17:47:55 EDT 2016] Signing Windows executable '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/win32/win32/x86/eclipsec.exe'
> [INFO] [Thu Aug 04 17:47:55 EDT 2016] Signing Windows executable '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/win32/win32/x86_64/eclipsec.exe'
> [INFO]
> [INFO] --- eclipse-macsigner-plugin:1.1.3:sign (default) @ org.eclipse.ice.product ---
> [INFO] [Thu Aug 04 17:48:19 EDT 2016] Signing OS X application '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/macosx/cocoa/x86_64/ICE.app'...
> [WARNING] [Thu Aug 04 17:53:51 EDT 2016] HTTP request failed.
> HTTP Error 502 (reason: Proxy Error)
> <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
> <html><head>
> <title>502 Proxy Error</title>
> </head><body>
> <h1>Proxy Error</h1>
> <p>The proxy server received an invalid
> response from an upstream server.<br />
> The proxy server could not handle the request <em><a href="/macsign.php">POST&nbsp;/macsign.php</a></em>.<p>
> Reason: <strong>Error reading from remote server</strong></p></p>
> </body></html>
> Server response has been saved to '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/macosx/cocoa/x86_64/ICE.app_5371999584385355738.zip-1650363203209436471-OSXAppSigner.log'
> [WARNING] [Thu Aug 04 17:59:15 EDT 2016] HTTP request failed.
> HTTP Error 502 (reason: Proxy Error)
> <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
> <html><head>
> <title>502 Proxy Error</title>
> </head><body>
> <h1>Proxy Error</h1>
> <p>The proxy server received an invalid
> response from an upstream server.<br />
> The proxy server could not handle the request <em><a href="/macsign.php">POST&nbsp;/macsign.php</a></em>.<p>
> Reason: <strong>Error reading from remote server</strong></p></p>
> </body></html>
> Server response has been saved to '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/macosx/cocoa/x86_64/ICE.app_5371999584385355738.zip-6194206691919150002-OSXAppSigner.log'
> [WARNING] [Thu Aug 04 18:04:45 EDT 2016] HTTP request failed.
> HTTP Error 502 (reason: Proxy Error)
> <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
> <html><head>
> <title>502 Proxy Error</title>
> </head><body>
> <h1>Proxy Error</h1>
> <p>The proxy server received an invalid
> response from an upstream server.<br />
> The proxy server could not handle the request <em><a href="/macsign.php">POST&nbsp;/macsign.php</a></em>.<p>
> Reason: <strong>Error reading from remote server</strong></p></p>
> </body></html>
> Server response has been saved to '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/macosx/cocoa/x86_64/ICE.app_5371999584385355738.zip-1454095004075517485-OSXAppSigner.log'
> [WARNING] [Thu Aug 04 18:11:33 EDT 2016] HTTP request failed.
> HTTP Error 502 (reason: Proxy Error)
> <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
> <html><head>
> <title>502 Proxy Error</title>
> </head><body>
> <h1>Proxy Error</h1>
> <p>The proxy server received an invalid
> response from an upstream server.<br />
> The proxy server could not handle the request <em><a href="/macsign.php">POST&nbsp;/macsign.php</a></em>.<p>
> Reason: <strong>Error reading from remote server</strong></p></p>
> </body></html>
> Server response has been saved to '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/macosx/cocoa/x86_64/ICE.app_5371999584385355738.zip-8749818717687278416-OSXAppSigner.log'
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] org.eclipse.ice.build ............................. SUCCESS [1.591s]
> [INFO] org.eclipse.ice.datastructures .................... SUCCESS [7.302s]
> [INFO] org.eclipse.ice.io ................................ SUCCESS [1.785s]
> [INFO] org.eclipse.ice.materials ......................... SUCCESS [1.978s]
> [INFO] org.eclipse.ice.item .............................. SUCCESS [4.199s]
> [INFO] org.eclipse.ice.caebat.batml ...................... SUCCESS [2.114s]
> [INFO] org.eclipse.ice.caebat.batml.test ................. SUCCESS [8:36.779s]
> [INFO] org.eclipse.ice.client.compatibility .............. SUCCESS [1.358s]
> [INFO] org.eclipse.ice.core .............................. SUCCESS [1.806s]
> [INFO] org.eclipse.ice.client ............................ SUCCESS [2.876s]
> [INFO] org.eclipse.ice.client.rcp ........................ SUCCESS [1.878s]
> [INFO] org.eclipse.ice.client.widgets .................... SUCCESS [5.340s]
> [INFO] org.eclipse.ice.client.test ....................... SUCCESS [18.891s]
> [INFO] org.eclipse.ice.persistence.xml ................... SUCCESS [1.630s]
> [INFO] org.eclipse.ice.reactor.plant ..................... SUCCESS [1.650s]
> [INFO] org.eclipse.ice.client.widgets.moose .............. SUCCESS [2.157s]
> [INFO] org.eclipse.ice.vibe .............................. SUCCESS [1.442s]
> [INFO] org.eclipse.ice.persistence.xml.test .............. SUCCESS [30.413s]
> [INFO] org.eclipse.ice.client.widgets.moose.test ......... SUCCESS [1.226s]
> [INFO] org.eclipse.ice.client.widgets.test.utils ......... SUCCESS [2.117s]
> [INFO] org.eclipse.ice.client.widgets.test ............... SUCCESS [31.576s]
> [INFO] org.eclipse.ice.core.test ......................... SUCCESS [5.009s]
> [INFO] org.eclipse.ice.datastructures.test ............... SUCCESS [2:26.504s]
> [INFO] org.eclipse.ice.developer ......................... SUCCESS [1.924s]
> [INFO] org.eclipse.ice.developer.moose ................... SUCCESS [3.192s]
> [INFO] org.eclipse.ice.io.test ........................... SUCCESS [4.909s]
> [INFO] org.eclipse.ice.item.test ......................... SUCCESS [10.781s]
> [INFO] org.eclipse.ice.materials.test .................... SUCCESS [4.070s]
> [INFO] org.eclipse.ice.materials.ui ...................... SUCCESS [2.234s]
> [INFO] org.eclipse.ice.reflectivity ...................... SUCCESS [1.524s]
> [INFO] org.eclipse.ice.reflectivity.ui ................... SUCCESS [1.661s]
> [INFO] ICE Advanced Materials Feature .................... SUCCESS [1.328s]
> [INFO] org.eclipse.ice.mesh .............................. SUCCESS [1.356s]
> [INFO] org.eclipse.ice.mesh.test ......................... SUCCESS [3.700s]
> [INFO] org.eclipse.ice.nek5000 ........................... SUCCESS [1.662s]
> [INFO] org.eclipse.ice.nek5000.test ...................... SUCCESS [5.817s]
> [INFO] org.eclipse.ice.projectgeneration ................. SUCCESS [1.828s]
> [INFO] org.eclipse.ice.projectgeneration.test ............ SUCCESS [35.771s]
> [INFO] org.eclipse.ice.proteus ........................... SUCCESS [1.389s]
> [INFO] org.eclipse.ice.proteus.test ...................... SUCCESS [6.628s]
> [INFO] org.eclipse.ice.reactor.plant.test ................ SUCCESS [11.005s]
> [INFO] org.eclipse.ice.reflectivity.test ................. SUCCESS [4.874s]
> [INFO] org.eclipse.ice.target.neon ....................... SUCCESS [0.228s]
> [INFO] org.eclipse.ice.vibe.test ......................... SUCCESS [4.616s]
> [INFO] ICE Feature ....................................... SUCCESS [1.342s]
> [INFO] ICE Repository .................................... SUCCESS [10.646s]
> [INFO] ICE Product ....................................... FAILURE [40:51.360s]
> [INFO] Eclipse ICE Build Aggregator ...................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 57:32.578s
> [INFO] Finished at: Thu Aug 04 18:11:33 EDT 2016
> [INFO] Final Memory: 298M/3389M
> [INFO] ------------------------------------------------------------------------
> [INFO] o.h.m.e.h.MavenExecutionResultHandler - Build failed with exception(s)
> [INFO] o.h.m.e.h.MavenExecutionResultHandler - [1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.cbi.maven.plugins:eclipse-macsigner-plugin:1.1.3:sign (default) on project org.eclipse.ice.product: [Thu Aug 04 18:11:33 EDT 2016] Signing of OS X application '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/macosx/cocoa/x86_64/ICE.app' failed. Activate debug (-X, --debug) to see why.
> [DEBUG] Closing connection to remote
> [ERROR] Failed to execute goal org.eclipse.cbi.maven.plugins:eclipse-macsigner-plugin:1.1.3:sign (default) on project org.eclipse.ice.product: [Thu Aug 04 18:11:33 EDT 2016] Signing of OS X application '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/macosx/cocoa/x86_64/ICE.app' failed. Activate debug (-X, --debug) to see why. -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.eclipse.cbi.maven.plugins:eclipse-macsigner-plugin:1.1.3:sign (default) on project org.eclipse.ice.product: [Thu Aug 04 18:11:33 EDT 2016] Signing of OS X application '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/macosx/cocoa/x86_64/ICE.app' failed. Activate debug (-X, --debug) to see why.
>       at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
>       at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
>       at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
>       at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>       at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>       at org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>       at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
>       at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:317)
>       at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:152)
>       at org.apache.maven.cli.MavenCli.execute(MavenCli.java:555)
>       at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:214)
>       at org.apache.maven.cli.MavenCli.main(MavenCli.java:158)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:497)
>       at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
>       at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
>       at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
>       at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: [Thu Aug 04 18:11:33 EDT 2016] Signing of OS X application '/jobs/genie.ice/ice-next/workspace/ice/org.eclipse.ice.product/target/products/ice.runtime.product/macosx/cocoa/x86_64/ICE.app' failed. Activate debug (-X, --debug) to see why.
>       at org.eclipse.cbi.maven.ExceptionHandler.handleError(ExceptionHandler.java:32)
>       at org.eclipse.cbi.maven.plugins.macsigner.OSXAppSigner.signApplication(OSXAppSigner.java:147)
>       at org.eclipse.cbi.maven.plugins.macsigner.OSXAppSigner.signApplications(OSXAppSigner.java:92)
>       at org.eclipse.cbi.maven.plugins.macsigner.SignMojo.execute(SignMojo.java:238)
>       at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
>       at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
>       ... 19 more
> [ERROR]
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please read the following articles:
> [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> [ERROR]
> [ERROR] After correcting the problems, you can resume the build with the command
> [ERROR]   mvn <goals> -rf :org.eclipse.ice.product
> [DEBUG] Waiting for process to finish
> [DEBUG] Result: 1
> Taking screenshot.
> [workspace] $ import -window root -display :1522 screenshot.jpg
> Terminating xvnc.
> Recording test results
> Archiving artifacts
> 
> --
> This message is automatically generated by Hudson.
> For more information on Hudson, see: http://hudson-ci.org/
> _______________________________________________
> ice-build mailing list
> ice-build@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ice-build
> 
> _______________________________________________
> ice-dev mailing list
> ice-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://dev.eclipse.org/mailman/listinfo/ice-dev



Back to the top