[ice-dev] Fwd: [ice-build] [eclipse/ice] cdf800: Closed the shells in th

[Jay Jay Billings <jayjaybillings@xxxxxxxxx>]

Everyone,

I finally fixed the build bug in next. Please take a minute to review the commit below so that this doesn't happen again.

This bug also popped up randomly on my dev machines, so it wasn't just a problem on the build server.

This was a very subtle bug. I found it by running the build manually on the build machine and looking at the screenshots produced by SWTBot. The problem was that the TableComponentCompositeTester was opening several shells and not closing them, which made it impossible for SWTBot to find the workbench. Remember that SWTBot only looks at the most recently activated shell, if you open one on top of the workbench then you need to close it. That is a good rule of thumb for shell manipulation anyway, just like memory management: if you open it, make sure it gets closed.

Jay

---------- Forwarded message ----------
From: "GitHub" <noreply@xxxxxxxxxx>
Date: Sep 20, 2015 11:37 PM
Subject: [ice-build] [eclipse/ice] cdf800: Closed the shells in the TableComponentComposite t...
To: <ice-build@xxxxxxxxxxx>
Cc:

  Branch: refs/heads/next
  Home:   https://github.com/eclipse/ice
  Commit: cdf80045fa5902f9ad8d178ace9d75d2317c188a
      https://github.com/eclipse/ice/commit/cdf80045fa5902f9ad8d178ace9d75d2317c188a
  Author: Jay Jay Billings <billingsjj@xxxxxxxx>
  Date:   2015-09-21 (Mon, 21 Sep 2015)

  Changed paths:
    M org.eclipse.ice.viz.service.test/src/org/eclipse/ice/viz/service/connections/preferences/test/TableComponentCompositeTester.java

  Log Message:
  -----------
  Closed the shells in the TableComponentComposite tests.

When I was testing the build on the dev machine I encountered a
situation where the shells opened from this test stacked up because they
were opened but never closed. Hopefully closing them will help the
build.

Signed-off-by: Jay Jay Billings <billingsjj@xxxxxxxx>



_______________________________________________
ice-build mailing list
ice-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-build