| Re: [ice-dev] Fwd: [ice-build] [eclipse/ice] 95588a: Fixed a possible index out of bounds exception. |
Yes, when I did it for Item it was over 500 lines.
Thanks Anna!
Jay
I just did this for Entry at it reduced the class size by over 300 lines... phew.
________________________________
From: ice-dev-bounces@xxxxxxxxxxx <ice-dev-bounces@xxxxxxxxxxx> on behalf of Jay J. Billings <billingsjj@xxxxxxxx>
Sent: Monday, February 23, 2015 4:48 PM
To: ice developer discussions
Subject: [ice-dev] Fwd: [ice-build] [eclipse/ice] 95588a: Fixed a possible index out of bounds exception.
Everyone,
I've noticed lately that you are all doing really cool things to clean up the code, like getting rid of our extra imports and removing TODO flags, like Jordan has done below. When you are doing this things, will you also please double check and clean up the documentation? A lot of our older classes have begin/end user code and @generated tags that could be removed and in many cases there are excess lines that are not needed. I've been cleaning up every file like this that I touch recently and I have found that it can account for as much as 25% of the documentation in the file. I addition to helping trim the fat, it will also make our documentation much more readable.
Jay
-------- Forwarded Message --------
Subject: [ice-build] [eclipse/ice] 95588a: Fixed a possible index out of bounds exception.
Date: Mon, 23 Feb 2015 13:22:26 -0800
From: GitHub <noreply@xxxxxxxxxx><mailto:noreply@xxxxxxxxxx>
Reply-To: GitHub <noreply@xxxxxxxxxx><mailto:noreply@xxxxxxxxxx>, Ice build notices <ice-build@xxxxxxxxxxx><mailto:ice-build@xxxxxxxxxxx>
To: ice-build@xxxxxxxxxxx<mailto:ice-build@xxxxxxxxxxx>
Branch: refs/heads/anna/postprocessing
Home: https://github.com/eclipse/ice
Commit: 95588a7e23227a51ed0a28973577bc8a5e2ad12c
https://github.com/eclipse/ice/commit/95588a7e23227a51ed0a28973577bc8a5e2ad12c
Author: Jordan Deyton <deytonjh@xxxxxxxx><mailto:deytonjh@xxxxxxxx>
Date: 2015-02-23 (Mon, 23 Feb 2015)
Changed paths:
M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEResourceView.java
Log Message:
-----------
Fixed a possible index out of bounds exception.
Removed an unnecessary cast that was generating a warning.
Removed a TODO flag.
Organized the imports.
Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx><mailto:deytonjh@xxxxxxxx>
_______________________________________________
ice-dev mailing list
ice-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-dev