Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ice-dev] Fwd: [ice-build] [eclipse/ice] 95588a: Fixed a possible index out of bounds exception.
Jay,

Sounds good to me!

Jordan
Jordan Deyton
Oak Ridge National Laboratory
Telephone: (865) 574-1091
Email: deytonjh@xxxxxxxx
On 2/23/2015 4:48 PM, Jay J. Billings wrote:
Everyone,

I've noticed lately that you are all doing really cool things to clean up the code, like getting rid of our extra imports and removing TODO flags, like Jordan has done below. When you are doing this things, will you also please double check and clean up the documentation? A lot of our older classes have begin/end user code and @generated tags that could be removed and in many cases there are excess lines that are not needed. I've been cleaning up every file like this that I touch recently and I have found that it can account for as much as 25% of the documentation in the file. I addition to helping trim the fat, it will also make our documentation much more readable.

Jay


-------- Forwarded Message --------
Subject: [ice-build] [eclipse/ice] 95588a: Fixed a possible index out of bounds exception.
Date: Mon, 23 Feb 2015 13:22:26 -0800
From: GitHub <noreply@xxxxxxxxxx>
Reply-To: GitHub <noreply@xxxxxxxxxx>, Ice build notices <ice-build@xxxxxxxxxxx>
To: ice-build@xxxxxxxxxxx 


  Branch: refs/heads/anna/postprocessing
  Home:   https://github.com/eclipse/ice
  Commit: 95588a7e23227a51ed0a28973577bc8a5e2ad12c
      https://github.com/eclipse/ice/commit/95588a7e23227a51ed0a28973577bc8a5e2ad12c
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-02-23 (Mon, 23 Feb 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEResourceView.java

  Log Message:
  -----------
  Fixed a possible index out of bounds exception.
Removed an unnecessary cast that was generating a warning.
Removed a TODO flag.
Organized the imports.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>








_______________________________________________
ice-dev mailing list
ice-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-dev

Back to the top