Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[ice-build] [eclipse/ice] c43b4a: Fixed a bug in LWRComponentWriter. Added a factory...

  Branch: refs/heads/jordan/hdf-refactor
  Home:   https://github.com/eclipse/ice
  Commit: c43b4acb29552a59dd7823f26d54f35bf5e3cca6
      https://github.com/eclipse/ice/commit/c43b4acb29552a59dd7823f26d54f35bf5e3cca6
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-08-28 (Fri, 28 Aug 2015)

  Changed paths:
    M src/org.eclipse.ice.reactor/src/org/eclipse/ice/reactor/hdf/LWRComponentWriter.java
    M tests/org.eclipse.ice.reactor.test/src/org/eclipse/ice/reactor/hdf/test/LWRComponentFactory.java
    M tests/org.eclipse.ice.reactor.test/src/org/eclipse/ice/reactor/hdf/test/LWRIOHandlerTester.java

  Log Message:
  -----------
  Fixed a bug in LWRComponentWriter. Added a factory method for old LWR.

1 - Added a method for generating an LWR with the same configuration
used in older tests to ensure the format has not changed.
2 - Updated LWRIOHandlerTester to include the old reactor in its tests.
3 - Fixed a bug in LWRComponentWriter. The LWRGridManager should not
create a "Positions" group in the file if there is no occupied grid
location in it.


Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


  Commit: f64aed98c37fc64fa8d5b4ba5b0406a4a4bf6adf
      https://github.com/eclipse/ice/commit/f64aed98c37fc64fa8d5b4ba5b0406a4a4bf6adf
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-08-28 (Fri, 28 Aug 2015)

  Changed paths:
    M tests/org.eclipse.ice.reactor.test/src/org/eclipse/ice/reactor/hdf/test/LWRComponentFactory.java
    M tests/org.eclipse.ice.reactor.test/src/org/eclipse/ice/reactor/hdf/test/LWRComponentReaderTester.java
    M tests/org.eclipse.ice.reactor.test/src/org/eclipse/ice/reactor/hdf/test/LWRComponentWriterTester.java
    M tests/org.eclipse.ice.reactor.test/src/org/eclipse/ice/reactor/hdf/test/LWRIOHandlerTester.java

  Log Message:
  -----------
  Adding missing licenses and documentation.

Fixed a bug in LWRComponentWriterTester and LWRComponentReaderTester.
Their RodClusterAssembly tests were testing FuelAssemblies instead.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


Compare: https://github.com/eclipse/ice/compare/e341459ffdc6...f64aed98c37f

Back to the top