[ice-build] [eclipse/ice] 8d1816: Prepared code for re-use in solution t

[GitHub <noreply@xxxxxxxxxx>]

  Branch: refs/heads/jordan/hdf-refactor
  Home:   https://github.com/eclipse/ice
  Commit: 8d1816233bbb473694cf89f5182b8f0f09042a72
      https://github.com/eclipse/ice/commit/8d1816233bbb473694cf89f5182b8f0f09042a72
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-08-17 (Mon, 17 Aug 2015)

  Changed paths:
    M src/org.eclipse.ice.io/src/org/eclipse/ice/io/hdf/HdfIOFactory.java
    M src/org.eclipse.ice.reactor.sfr/META-INF/MANIFEST.MF
    M src/org.eclipse.ice.reactor.sfr/src/org/eclipse/ice/reactor/sfr/base/SFReactorIOHandler.java

  Log Message:
  -----------
  Prepared code for re-use in solution to bug 474744.

Since the LWR HDF IO code is being updated to read like the
SFReactorIOHandler, there's a lot of potential for code re-use. Much of
the HDF IO code in the SFReactorIOHandler was already copied to
HdfIOFactory, so I made SFReactorIOHandler a sub-class of it to re-use
the code.

Also fixed a bug regarding reading strings from HDF. HDF uses native,
null-terminated strings. The LWR writer currently does not write
null-terminated strings, so I added logic to HdfIOFactory to check for a
null-string when reading in string attributes.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


  Commit: e2ce0aa040c44a862ccb7b975f6398b812992ff3
      https://github.com/eclipse/ice/commit/e2ce0aa040c44a862ccb7b975f6398b812992ff3
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-08-17 (Mon, 17 Aug 2015)

  Changed paths:
    M src/org.eclipse.ice.io/src/org/eclipse/ice/io/hdf/HdfIOFactory.java
    M src/org.eclipse.ice.reactor.plant/src/org/eclipse/ice/reactor/plant/PlantComponentReader.java
    M src/org.eclipse.ice.reactor.plant/src/org/eclipse/ice/reactor/plant/PlantComponentWriter.java
    M src/org.eclipse.ice.reactor.sfr/src/org/eclipse/ice/reactor/sfr/base/SFReactorIOHandler.java

  Log Message:
  -----------
  Refactored the Hdf IO methods for ICEObjects to instead use Identifiable

Also updated the SFR HDF reader/writer to use these methods instead of
manually reading in each SFRComponent's name, description, and ID.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


  Commit: bfa1840f225ce0d40efa10d2ad40e9109e5c7f2c
      https://github.com/eclipse/ice/commit/bfa1840f225ce0d40efa10d2ad40e9109e5c7f2c
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-08-17 (Mon, 17 Aug 2015)

  Changed paths:
    M src/org.eclipse.ice.io/src/org/eclipse/ice/io/hdf/HdfIOFactory.java
    M src/org.eclipse.ice.reactor.plant/src/org/eclipse/ice/reactor/plant/PlantComponentReader.java
    M src/org.eclipse.ice.reactor.plant/src/org/eclipse/ice/reactor/plant/PlantComponentWriter.java
    M src/org.eclipse.ice.reactor.sfr/src/org/eclipse/ice/reactor/sfr/base/SFReactorIOHandler.java

  Log Message:
  -----------
  Minor refactor of HdfIOFactory methods.

This makes reading/writing ints and doubles easier to read and type.

Also made a few methods private as they are not used by sub-classes of
HdfIOFactory.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


  Commit: d93a888bd1a21d123a9d06abc3f75087ec48d0d6
      https://github.com/eclipse/ice/commit/d93a888bd1a21d123a9d06abc3f75087ec48d0d6
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M src/org.eclipse.ice.reactor/src/org/eclipse/ice/reactor/pwr/PWRAssembly.java

  Log Message:
  -----------
  Removed some rather odd, non-alpha-numeric characters from a comment.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


Compare: https://github.com/eclipse/ice/compare/8d1816233bbb^...d93a888bd1a2