Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[ice-build] [eclipse/ice] bc266c: Re-organized the code in CSVPlot.load(). The code ...

  Branch: refs/heads/master
  Home:   https://github.com/eclipse/ice
  Commit: bc266c7d3f183df1a956222b541728ca4fb54b1e
      https://github.com/eclipse/ice/commit/bc266c7d3f183df1a956222b541728ca4fb54b1e
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-04-21 (Tue, 21 Apr 2015)

  Changed paths:
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/csv/CSVPlot.java

  Log Message:
  -----------
  Re-organized the code in CSVPlot.load(). The code that actually loads
the CSV file is now contained in a private method, load(File), making it
much easier to read. The load() method still kicks off a thread that
calls this private method.

Re-ordered the series names. Now they are presented as "y-variable vs.
x-variable", which is a pretty standard convention.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


  Commit: c7a0033aa1915236e0b3f7d7a52de925962407b0
      https://github.com/eclipse/ice/commit/c7a0033aa1915236e0b3f7d7a52de925962407b0
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-04-21 (Tue, 21 Apr 2015)

  Changed paths:
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/csv/CSVPlot.java
    M src/org.eclipse.ice.viz/src/org/eclipse/ice/viz/plotviewer/CSVDataProvider.java

  Log Message:
  -----------
  Fixed the CSVDataProvider, which was relocating the data for
"independent variables" or features, resulting in the data not being
found later. Now, any two features can be plotted against each other if
one or both is set as an independent variable.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


  Commit: c37f66c13c44954f604c5af5bce5c430bdfecd2e
      https://github.com/eclipse/ice/commit/c37f66c13c44954f604c5af5bce5c430bdfecd2e
  Author: Jordan Deyton <deytonjh@xxxxxxxx>
  Date:   2015-04-21 (Tue, 21 Apr 2015)

  Changed paths:
    M src/org.eclipse.ice.viz/src/org/eclipse/ice/viz/plotviewer/CSVDataProvider.java
    M src/org.eclipse.ice.viz/src/org/eclipse/ice/viz/plotviewer/CSVDataTableViewer.java
    M tests/org.eclipse.ice.viz.test/src/org/eclipse/ice/viz/plotviewer/test/PlotTreeContentProviderTester.java

  Log Message:
  -----------
  Cleaned up a lot of code for readability in CSVDataProvider, simplifying
some bits here and there. I also added some documentation to some of the
more complicated methods.

Organized imports in the other two classes to clear warnings.

Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>


Compare: https://github.com/eclipse/ice/compare/03ed7275581d...c37f66c13c44

Back to the top