Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ice-build] [eclipse/ice] c3cff8: Added a getResourcePage() method to ICEFormEditor ...
Works like a charm! Great job, Anna!

Despite a few related bugs that we need to fix in the next few days, I think it works well enough to merge the changes to master, so everyone else can play around with the grid layout. I've got a few old TODO and FIXME tags that can be removed first, so after removing them I'll merge the changes back into master.

Jordan
Jordan Deyton
Oak Ridge National Laboratory
Telephone: (865) 574-1091
Email: deytonjh@xxxxxxxx
On 4/13/2015 6:28 PM, GitHub wrote:
  Branch: refs/heads/anna/gridlayout
  Home:   https://github.com/eclipse/ice
  Commit: c3cff865d89a2826d8e18254ee35098e4e016e84
      https://github.com/eclipse/ice/commit/c3cff865d89a2826d8e18254ee35098e4e016e84
  Author: Anna Wojtowicz <wojtowicza@xxxxxxxx>
  Date:   2015-04-13 (Mon, 13 Apr 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEFormEditor.java
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEResourcePage.java
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEResourceView.java

  Log Message:
  -----------
  Added a getResourcePage() method to ICEFormEditor for ICEResourceView to
get a handle on its associated ResourcePage. This eliminated the need
for ICEResourcePage.selectionChanged() to try to filter the location of
events, instead letting the ResourceView directly tell the ResourcePage
to draw. Then added a double-click listener on ICEResourceView, so
resources will be shown/plotted with a double click instead of single.
Cleaned up documentation.

Signed-off-by: Anna Wojtowicz <wojtowicza@xxxxxxxx>


  Commit: 4253fe1d927e788e9af1a936f22033a54125da91
      https://github.com/eclipse/ice/commit/4253fe1d927e788e9af1a936f22033a54125da91
  Author: Anna Wojtowicz <wojtowicza@xxxxxxxx>
  Date:   2015-04-13 (Mon, 13 Apr 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/PlotGridComposite.java

  Log Message:
  -----------
  Merge branch 'anna/gridlayout' of https://github.com/eclipse/ice into anna/gridlayout


Compare: https://github.com/eclipse/ice/compare/a2f251414686...4253fe1d927e


_______________________________________________
ice-build mailing list
ice-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-build

Back to the top