Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ice-build] [eclipse/ice] 28311a: Was able to finally fix the widget disposed error ...
Finding bugs like that is always difficult. Great job!

Jordan
Jordan Deyton
Oak Ridge National Laboratory
Telephone: (865) 574-1091
Email: deytonjh@xxxxxxxx
On 2/12/2015 6:56 PM, GitHub wrote:
  Branch: refs/heads/anna/postprocessing
  Home:   https://github.com/eclipse/ice
  Commit: 28311a339a2158f04b0df35073a7cee75892328b
      https://github.com/eclipse/ice/commit/28311a339a2158f04b0df35073a7cee75892328b
  Author: Anna Wojtowicz <wojtowicza@xxxxxxxx>
  Date:   2015-02-12 (Thu, 12 Feb 2015)

  Changed paths:
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEResourcePage.java
    M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEResourceView.java
    M src/org.eclipse.ice.item/src/org/eclipse/ice/item/nuclear/MOOSEModel.java
    M src/org.eclipse.ice.viz.service/src/org/eclipse/ice/viz/service/csv/CSVVizService.java

  Log Message:
  -----------
  Was able to finally fix the widget disposed error I was getting when
trying to plot files. 

When a ICEResourcePage was closed and it disposed of its widgets, the
page wasn't removed from the workbench's SelectionService listeners. So
everytime the SelectionService updated its listeners at a later point
(like when another MOOSE Launcher tried to plot files), it also
attempted to update the old ICEResourcePages with disposed widgets,
causing the error.

I added a DisposeListener onto the ICEResourcePage's main composite, so
when it's the composite's time to go, the ICEResourcePage is also
unregistered to get updates from the SelectionService.

Fixes bug 459707.

Signed-off-by: Anna Wojtowicz <wojtowicza@xxxxxxxx>





_______________________________________________
ice-build mailing list
ice-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-build

Back to the top