Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ice-build] [eclipse/ice] bc261d: Updating Caebat Launcher to allow for easier selec...

Andrew,

I noticed here that you let CaebatLauncher implement the IUpdateableListener interface. But Item already implements this interface. You should remove it from the CaebatLauncher and just override Item/JobLauncher’s update method.

Alex

On Feb 4, 2015, at 10:55 PM, GitHub <noreply@xxxxxxxxxx<mailto:noreply@xxxxxxxxxx>> wrote:

 Branch: refs/heads/andrew/caebat
 Home:   https://github.com/eclipse/ice
 Commit: bc261dd66ba256532de66354993c55e2d6504d7b
     https://github.com/eclipse/ice/commit/bc261dd66ba256532de66354993c55e2d6504d7b
 Author: arbennett <bennettar@xxxxxxxx<mailto:bennettar@xxxxxxxx>>
 Date:   2015-02-04 (Wed, 04 Feb 2015)

 Changed paths:
   M src/org.eclipse.ice.caebat/src/org/eclipse/ice/caebat/launcher/CaebatLauncher.java

 Log Message:
 -----------
 Updating Caebat Launcher to allow for easier selecting of a custom KV
pair file.


 Commit: 35cbdf24ce83c48b5d9fbfb302018ad73c7ae495
     https://github.com/eclipse/ice/commit/35cbdf24ce83c48b5d9fbfb302018ad73c7ae495
 Author: arbennett <bennettar@xxxxxxxx<mailto:bennettar@xxxxxxxx>>
 Date:   2015-02-04 (Wed, 04 Feb 2015)

 Changed paths:
   M src/org.eclipse.ice.io/.classpath
   M src/org.eclipse.ice.io/META-INF/MANIFEST.MF
   M tests/org.eclipse.ice.io.test/.classpath
   M tests/org.eclipse.ice.io.test/META-INF/MANIFEST.MF

 Log Message:
 -----------
 Merge branch 'andrew/caebat' of https://github.com/eclipse/ice.git into andrew/caebat


Compare: https://github.com/eclipse/ice/compare/20904b0de21d...35cbdf24ce83_______________________________________________
ice-build mailing list
ice-build@xxxxxxxxxxx<mailto:ice-build@xxxxxxxxxxx>
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/ice-build

Alex McCaskey
ORNL Computer Science Research
mccaskeyaj@xxxxxxxx<mailto:mccaskeyaj@xxxxxxxx>
(865) 574-8715





Back to the top