[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
[ice-build] [eclipse/ice] 655bd7: Fixed a whole lot of warnings due to raw ArrayList...
|
Branch: refs/heads/master
Home: https://github.com/eclipse/ice
Commit: 655bd78edcc02ee1047401c90311194bc86a99a8
https://github.com/eclipse/ice/commit/655bd78edcc02ee1047401c90311194bc86a99a8
Author: Jordan Deyton <deytonjh@xxxxxxxx>
Date: 2014-12-04 (Thu, 04 Dec 2014)
Changed paths:
M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEMatrixComponentSectionPart.java
Log Message:
-----------
Fixed a whole lot of warnings due to raw ArrayLists with no type
specified.
Converted all of the SelectionListeners to SelectionAdapters to
eliminate unnecessary code.
Re-formatted some comments to reduce the number of lines.
Organized imports.
Converted most ArrayLists to Lists when possible.
Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>
Commit: 33cca7f39a0b1538d78fcda9b8e23b20b80b377e
https://github.com/eclipse/ice/commit/33cca7f39a0b1538d78fcda9b8e23b20b80b377e
Author: Jordan Deyton <deytonjh@xxxxxxxx>
Date: 2014-12-04 (Thu, 04 Dec 2014)
Changed paths:
M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICETableComponentSectionPart.java
Log Message:
-----------
Converted some ArrayLists to Lists and SelectionListeners to
SelectionAdapters to eliminate some unnecessary code.
Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>
Commit: fdbdccb2df3c79ed46304793cb4e0d3c8c311357
https://github.com/eclipse/ice/commit/fdbdccb2df3c79ed46304793cb4e0d3c8c311357
Author: Jordan Deyton <deytonjh@xxxxxxxx>
Date: 2014-12-04 (Thu, 04 Dec 2014)
Changed paths:
R src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/EntryComposite.java.merge-left.r4577
R src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/EntryComposite.java.merge-right.r4882
R src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/EntryComposite.java.working
Log Message:
-----------
Removing some errant merge files from the client.widgets bundle.
Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>
Commit: 4260533d5d7aed64429f722c4a0df9d0e8c8baf1
https://github.com/eclipse/ice/commit/4260533d5d7aed64429f722c4a0df9d0e8c8baf1
Author: Jordan Deyton <deytonjh@xxxxxxxx>
Date: 2014-12-04 (Thu, 04 Dec 2014)
Changed paths:
M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEDataComponentSectionPart.java
Log Message:
-----------
Removed a lot of unnecessary code from ICEDataComponentSectionPart.
Streamlined the renderSection() code since there was an unnecessary
Composite with a FillLayout.
Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>
Commit: cd7b8b6edbbf24ff52afffe09f73f1e529aa06e7
https://github.com/eclipse/ice/commit/cd7b8b6edbbf24ff52afffe09f73f1e529aa06e7
Author: Jordan Deyton <deytonjh@xxxxxxxx>
Date: 2014-12-04 (Thu, 04 Dec 2014)
Changed paths:
M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/DataComponentComposite.java
M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICEDataComponentSectionPart.java
Log Message:
-----------
Fixed calls to deprecated GridData style bits.
Hooked up the DataComponentComposite to be properly decorated by the
FormToolkit if one is available.
Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>
Commit: 81859152cd1fa13657c4e80d47be8d0400add782
https://github.com/eclipse/ice/commit/81859152cd1fa13657c4e80d47be8d0400add782
Author: Jordan Deyton <deytonjh@xxxxxxxx>
Date: 2014-12-04 (Thu, 04 Dec 2014)
Changed paths:
M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ICESectionPage.java
A src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/PadFinder.java
A src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/ScrollClientComposite.java
Log Message:
-----------
Adding code to fix a UI bug in the ICESectionPage.
I cleaned all of the code that creates the DataComponent,
TableComponent, and MatrixComponent sections. There was a bit of
unnecessary code there.
Added missing documentation and removed a lot of unnecessary tags and
empty lines.
ScrollClientComposite is a custom Composite that will re-adjust its size
based on the width of a parent SharedScrollComposite (which is used in
the Eclipse ScrolledForm) or a minimum size. Effectively, the default
preferred size of the DataComponent Sections in the ICESectionPage are
ignored because sometimes their preferred sizes are absurdly long (e.g.,
a Combo with a very long String).
PadFinder is used to find horizontal padding resulting from FillLayouts
and GridLayouts lying between the ScrollClientComposite and its ancestor
SharedScrolledComposite. This makes the resizing in
ScrollClientComposite a little smoother and more accurate.
Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>
Commit: fc3327b60acfc6001d19923005ba0a5d95c30854
https://github.com/eclipse/ice/commit/fc3327b60acfc6001d19923005ba0a5d95c30854
Author: Jordan Deyton <deytonjh@xxxxxxxx>
Date: 2014-12-04 (Thu, 04 Dec 2014)
Changed paths:
M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/DataComponentComposite.java
M src/org.eclipse.ice.client.widgets/src/org/eclipse/ice/client/widgets/EntryComposite.java
Log Message:
-----------
Significant cleanup and bug-fixes for EntryComposite:
1) Reorganized the way the EntryComposite is laid out so I could remove
a constructor.
2) Replaced several listeners with adapters to eliminate unnecessary
calls to widgetDefaultSelected() or otherwise empty listener methods.
3) Replaced several ArrayLists (local to this class) with Lists.
4) The EntryComposite now manages its own layout completely on its own.
Previously, there was some logic that tried to set the layout from the
DataComponentComposite, but that logic was moved to EntryComposite.
5) Labels created by EntryComposite now wrap if necessary.
6) If the EntryComposite is for a file Entry, it uses a RowLayout. The
dropdown list of files grabs all excess space.
Signed-off-by: Jordan Deyton <deytonjh@xxxxxxxx>
Compare: https://github.com/eclipse/ice/compare/99fe0b541573...fc3327b60acf
