Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [hono-dev] Definition of Hono's public API


On 29.01.20 09:48, Kalidass Kartheeswaran (IOC/PAP-HU) wrote:
>> -----Original Message-----
>> From: hono-dev-bounces@xxxxxxxxxxx <hono-dev-bounces@xxxxxxxxxxx> On
>> Behalf Of Lohmann Carsten (IOC/PAP-HU)
>> Sent: Mittwoch, 29. Januar 2020 09:23
>> To: hono developer discussions <hono-dev@xxxxxxxxxxx>
>> Subject: Re: [hono-dev] Definition of Hono's public API
>>
>>>> Regarding the "service-base" module, as I see it, the following
>>>> classes in
>>> "org/eclipse/hono/service" directly represent the device registry base classes:
>>>> ---
>>>> auth/
>>>>   AuthenticationService.java
>>>>
>>>> credentials/
>>>>   CredentialsService.java
>>>>   EventBusCredentialsAdapter.java
>>>>
>>>> deviceconnection/
>>>>   DeviceConnectionService.java
>>>>   EventBusDeviceConnectionAdapter.java
>>>>
>>>> management/
>>>>   credentials/
>>>>      CredentialsManagementService.java
>>>>      EventBusCredentialsManagementAdapter.java
>>>>   device/
>>>>      DeviceManagementService.java
>>>>      EventBusDeviceManagementAdapter.java
>>>>      (possibly also DeviceBackend.java)
>>>>   tenant/
>>>>      TenantManagementService.java
>>>>      EventBusTenantManagementAdapter.java
>>>>      (possibly also TenantBackend.java)
>>>>
>>>> registration/
>>>>   EventBusRegistrationAdapter.java
>>>>   RegistrationService.java
>>>>
>>>> tenant/
>>>>   EventBusTenantAdapter.java
>>>>   TenantService.java
>>>> ---
>>>>
>>>
>>> What about
>>> management/
>>>   credentials/
>>>     CredentialsManagementHttpEndpoint
>>>
>>>   device/
>>>     DeviceManagementHttpEndpoint
>>>
>>>   tenant/
>>>     TenantManagementHttpEndpoint
>>
>>
>> Right, these as well.
>> I guess it would make sense to include the *AmqpEndpoint classes as well (e.g.
>> RegistrationAmqpEndpoint), and also AbstractRegistrationService.
>>
> 
> I think in addition to the AmqpEndpoint, the resource-limit checks API (ResourceLimitChecks) can also be added as public. 
> We informed in the documentation, that the users can bring their own custom implementation of this API.
> FMPOV it makes sense to include it for sematic versioning.
> 

If we consider all protocol adapter implementations private and we
actually now discourage people from implementing custom adapters but
instead use protocol gateways in front of the AMQP adapter, I wonder who
would need/want to implement this API?

-- 
Mit freundlichen Grüßen / Best regards

Kai Hudalla

Software Developer - Bosch IoT Hub

Bosch.IO GmbH
Ullsteinstr. 128
12109 Berlin
GERMANY
www.bosch.io

Registered Office: Berlin, Registration Court: Amtsgericht
Charlottenburg; HRB 148411 B
Chairman of the Supervisory Board: Dr.-Ing. Thorsten Lücke;
Managing Directors: Dr. Stefan Ferber, Dr. Aleksandar Mitrovic, Yvonne
Reckling

Back to the top