Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [hono-dev] More checkstyle?! – Adding the "final" keyword

+1
-- 
Mit freundlichen Grüßen / Best regards

Kai Hudalla
Chief Software Architect

Bosch Software Innovations GmbH
Ullsteinstr. 128
12109 Berlin
GERMANY
www.bosch-si.com

Registered Office: Berlin, Registration Court: Amtsgericht Charlottenburg; HRB
148411 B
Chairman of the Supervisory Board: Dr.-Ing. Thorsten Lücke; Managing Directors:
Dr. Stefan Ferber, Michael Hahn


On Fri, 2018-04-20 at 09:56 +0200, Jens Reimann wrote:
> @sysexcontrol mentioned the use of "final" for parameters in a recent GitHub
> PR: https://github.com/eclipse/hono/pull/561#discussion_r182801072
> 
> I fully agree. Hono already uses this on most locations. But not on all.
> 
> A did add a checkstyle rule for this, just for testing. The impact is not that
> big.
> 
> But as this again is about code style I would like to ask first if anyone
> objects adding this checkstyle check.
> 
> Otherwise I would continue with this addition and push it.
> 
> Cheers
> 
> Jens
> 
> _______________________________________________
> hono-dev mailing list
> hono-dev@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from
> this list, visit
> https://dev.eclipse.org/mailman/listinfo/hono-dev

Back to the top