Re: [hono-dev] More checkstyle?! – Adding the "final" keyword

[Dejan Bosanac <dejanb@xxxxxxxxxxxx>]

+1 It’d help make things consistent in the codebase.

On Fri, Apr 20, 2018 at 9:56 AM, Jens Reimann <jreimann@xxxxxxxxxx> wrote:

@sysexcontrol mentioned the use of "final" for parameters in a recent GitHub PR: https://github.com/eclipse/hono/pull/561#discussion_r182801072

I fully agree. Hono already uses this on most locations. But not on all.

A did add a checkstyle rule for this, just for testing. The impact is not that big.

But as this again is about code style I would like to ask first if anyone objects adding this checkstyle check.

Otherwise I would continue with this addition and push it.

Cheers

Jens

--

Jens Reimann
Senior Software Engineer / EMEA ENG Middleware
Werner-von-Siemens-Ring 14
85630 Grasbrunn
Germany
phone: +49 89 2050 71286
_____________________________________________________________________________

Red Hat GmbH, www.de.redhat.com,
Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Paul Argiry, Charles Cachera, Michael Cunningham, Michael O'Neill

_______________________________________________
hono-dev mailing list
hono-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/hono-dev

--

Regards
--
Dejan Bosanac
http://sensatic.net/about