Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [higgins-dev] For Check-in : Google Contacts CP
Hi Markus,

Thanks very much for testing it out! Yes, you're right - @Override annotation can be used on interface methods only from JDK 6 and since I'm using JDK 6, I didn't catch that.

For now, CP only exposes the Google contacts as Entities and not the user's account. I shall add that feature in my next check-in.

As per Mary, we've got the approval from Eclipse Legal for GData libraries. (Attached Mary's note on the approval).

Thanks so much for checking-in the code!

Thanks,
Mohamad Raja
Oracle

Markus Sabadello wrote:
Hi Mohamad,

I had a tiny problem when trying it: I think that in Java 5, the @Override annotation can only be used when overriding a method from a superclass, not when implementing a method of an interface. So I had compilation errors in GDataContextFactory.java.

If I switch to Java 6, or alternatively just remove all the @Override annotations, it seems to work fine! I can see the test class print out my Google contacts!

Another question: Does the CP only expose the Google contacts as IdAS Entities, or does it also expose MY own Google account (the one I am opening) as one of the IdAS Entities?

BTW I'd be happy to check in the code unless anyone sees a problem with that! Not sure if we can check in all the dependencies (we can only check in Eclipse-approved dependencies)

Markus

2009/3/19 Mohamad Raja Gani <mohamad.raja@xxxxxxxxxx>
Hello All,

I have completed the implementation of IdAS Google Contacts CP that includes update to contacts. Please find attached the CP source code & GData dependent library.  I kindly request one of the contributors to review and check-in the code & dependant library. Can you also please integrate with the build as I've no idea on the build process.

Please note that this implementation is based on JDK 1.5 as the underlying GData Java client library is on 1.5.

Thanks,
Mohamad Raja
Oracle

_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev



_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev

--- Begin Message ---
Good News. Eclipse Legal finished reviewing the GData code and it is now approved for use by Higgins and it is now OK to check it into the Higgins SVN.
 
-Mary

From: Mary Ruddy [mailto:mary@xxxxxxxxxxxxxxxxx]
Sent: Monday, December 15, 2008 9:53 AM
To: 'Higgins (Trust Framework) Project developer discussions'
Cc: 'brian walker'; 'Pervez Goiporia'; 'Tom Doman'
Subject: RE: [higgins-dev] For Review: Google Contacts CP

Mohamad,
 
Eclipse legal expects to complete the GData review in January.  So we will need to wait until then.
 
-Mary

From: higgins-dev-bounces@xxxxxxxxxxx [mailto:higgins-dev-bounces@xxxxxxxxxxx] On Behalf Of Mary Ruddy
Sent: Friday, December 12, 2008 11:18 AM
To: 'Higgins (Trust Framework) Project developer discussions'
Cc: 'brian walker'; 'Pervez Goiporia'; 'Tom Doman'
Subject: RE: [higgins-dev] For Review: Google Contacts CP

Mohamad,
 
There is no problem per se, but the IP review (CQ 2533) for the Gdata hasn't been completed yet, so we don't yet have permission to put it into our SVN.  Have pinged Eclipse legal to check on the status.
 
-Mary

From: higgins-dev-bounces@xxxxxxxxxxx [mailto:higgins-dev-bounces@xxxxxxxxxxx] On Behalf Of Mohamad Raja Gani
Sent: Friday, December 12, 2008 10:59 AM
To: Higgins (Trust Framework) Project developer discussions
Cc: 'brian walker'; 'Pervez Goiporia'; 'Tom Doman'
Subject: Re: [higgins-dev] For Review: Google Contacts CP

Hi Mary,

GData libraries are required for both build & runtime. Do you see any problem in having these libraries as dependencies?

Thanks,
Mohamad Raja
Oracle

Mary Ruddy wrote: 
Markus,

Did you just need the gdata jars at runtime or also at build time?

-Mary

-----Original Message-----
From: higgins-dev-bounces@xxxxxxxxxxx
[mailto:higgins-dev-bounces@xxxxxxxxxxx] On Behalf Of Markus Sabadello
Sent: Friday, December 12, 2008 3:23 AM
To: Higgins (Trust Framework) Project developer discussions
Cc: Pervez Goiporia; brian walker; Tom Doman
Subject: Re: [higgins-dev] For Review: Google Contacts CP

Hmm not sure what you mean with artifacts. Basically, you just check in your
project into the Eclipse Higgins SVN (in the plugins/ folder), add it to the
http://wiki.eclipse.org/Components page, and then you can add the project to
the automated build system, according to
http://wiki.eclipse.org/Automated_Builds. Or if you ask nicely on the list,
I think someone else could do that for you :)

Markus

On Fri, Dec 12, 2008 at 8:29 AM, Mohamad Raja Gani <mohamad.raja@xxxxxxxxxx>
wrote:
  
Hi Markus,

Thanks very much for trying this implementation! Yes, since it is 
developed using GData Java client library, the jars you mentioned are
    
required.
  
I shall make few more changes to the code and send it out for final
    
review.
  
Can you please let me know the artifacts that I need to generate as 
part of this package and how to do it? I will close bug 229639 once 
the code gets checked-in.

Thanks,
Mohamad Raja
Oracle

Markus Sabadello wrote:

Hi Mohamad,

I tried it and it works for me! I was able to read my Google contacts 
and to create a new one with the CP.

I had to manually install the following .jars:
gdata-client-1.0.jar
gdata-contacts-2.0.jar
gdata-core-1.0.jar
gdata-contacts-meta-2.0.jar
gdata-client-meta-1.0.jar

Does that look right?

Also, I had to move the .xrds file from src/ to the project root 
folder, but that's probably because I ran it from within Eclipse.

Markus

On Thu, Dec 11, 2008 at 5:16 PM, Mohamad Raja Gani 
<mohamad.raja@xxxxxxxxxx> wrote:


Hello All,

I have completed the initial implementation of IdAS Google Contacts 
Context Provider and would like to get it reviewed from you. Please 
find attached the CP source code.  I'm in the process of adding 
support for contacts update & group membership and can make it ready 
for 1.1M5. In the mean time, I'd appreciate your comments & feedback on
    
this implementation.
  
Please note that this implementation is based on JDK 1.5 as the 
underlying GData Java client library is on 1.5.

Thanks,
Mohamad Raja
Oracle

_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev




_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev


_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev


    
_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev



_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev
  

_______________________________________________
higgins-dev mailing list
higgins-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/higgins-dev

--- End Message ---

Back to the top