Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [handly-dev] Enabling working sets breaks the navigator

You're right, it didn't work for me too (must be a CNF bug?) But it would actually be better to add each extension separately (more control).
 
Also, I forgot to mention that adapters from model elements to IResource should be in place for these o.e.navigator.resources action providers to work (though it is probably obvious).
 
Best regards,
Vladimir
 
 
Thanks!

I tried to exclude the working set actions, but it didn't work... I suppose I will have to add each set separately.

regards,
Vlad


On Fri, Dec 19, 2014 at 12:31 PM, Vladimir Piskarev <pisv@xxxxx> wrote:
Hi Vlad,
 
Thanks for reporting it!
 
I can reproduce this issue. Unfortunately, it cannot be easily solved (as far as I can see). This working set support in o.e.ui.navigator.resources is designed to work (only) with the resource-based ProjectExplorer (a subclass of CommonNavigator). For Handly-based content, we need something along the lines of working set support in JDT's PackageExplorerPart (see WorkingSetModel). I hope to come up with a solution for that in Handly 0.3. Meanwhile, you can exclude org.eclipse.ui.navigator.resources.WorkingSetActions as a workaround.
 
In particular, these action extensions from o.e.ui.navigator.resources are known to work well with Handly-based content:
 
            <actionExtension
                  pattern="org.eclipse.ui.navigator.resources.UndoRedoActionProvider">
            </actionExtension>
            <actionExtension
                  pattern="org.eclipse.ui.navigator.resources.PortingActions">
            </actionExtension>
            <actionExtension
                  pattern="org.eclipse.ui.navigator.resources.ResourceMgmtActions">
            </actionExtension>
            <actionExtension
                  pattern="org.eclipse.ui.navigator.resources.PropertiesActionProvider">
            </actionExtension>
Best regards,
Vladimir
 
Hi,

If adding to the navigator (as implemented in the examples) an actionExtension to "org.eclipse.ui.navigator.resources..*", which among other things enables working sets in the view, this extension resets the navigator's content provider input to the workspace. This means that the navigator loses all Handly-based content because that depends on the model being the navigator's input.

Do you have any suggestion about how to handle this? I tried different combinations of adapters (because I feel that being able to adapt IResources to IFooElements should be a solution), but couldn't make it work -- either it's not a good solution, or I did it wrong... 

At some time in the future, one will probably want to support working sets anyway, so removing these extensions is only a temporary solution.

best regards,
Vlad


_______________________________________________
handly-dev mailing list
handly-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://dev.eclipse.org/mailman/listinfo/handly-dev

Back to the top