[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [gmf-dev] IUndoableOperation changes in the platform cause AssertionFailedException and breaks GMF
|
Looking at BaseEditHelper.xpt, it was simple to find this:
new org.eclipse.gmf.runtime.common.core.command.CompositeCommand(null);
Looking at the constructor, it doesn't seem like it will help us any (passes
the null).
I'll open a bug to fix our templates.
- Rich
On 4/2/08 1:01 PM, "Artem Tikhomirov" <Artem.Tikhomirov@xxxxxxxxxxx> wrote:
> Anthony,
>
> As I understood, templates/generated code should not be necessarily modified
> as the nulls passed would be anyway replaced with "" in the AbstractOperation,
> right?
>
> Artem
>
>> -----Original Message-----
>> From: gmf-dev-bounces@xxxxxxxxxxx
>> [mailto:gmf-dev-bounces@xxxxxxxxxxx] On Behalf Of Anthony Hunter
>> Sent: Friday, March 28, 2008 8:35 PM
>> To: gmf-dev@xxxxxxxxxxx
>> Cc: platform-ui@xxxxxxxxxxx
>> Subject: [gmf-dev] IUndoableOperation changes in the platform
>> cause AssertionFailedException and breaks GMF
>>
>>
>> Hi Team,
>>
>> As a result of the fix in
>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=218467 you can
>> no longer create a GMF command with a null label.
>>
>> I raised https://bugs.eclipse.org/bugs/show_bug.cgi?id=224706
>> on the GMF Runtime but this affects the GMF tooling's
>> generated code as well.
>>
>> It is a common use case to create GMF commands without a label.
>>
>> CompositeCommand with a label and the composite command
>> wrapping commands without a label.
>> We also use commands that do not have to show up in the undo
>> stack, so some have null labels.
>> It would appear we have use cases where the label is created
>> after the command is created (i.e by looking up a translated
>> string and calling setLabel()).
>>
>> I am trying to access how major a problem this is, but our
>> GMF clients are not going to any backward compatibility when
>> they adopt M6 (i.e. M6 will require everyone to regenerate
>> their code).
>>
>> I assume it is ok to replace null with "" but this means we
>> are creating additional strings.
>>
>> Cheers...
>> Anthony
>> --
>> Anthony Hunter mailto:anthonyh@xxxxxxxxxx Software
>> Development Manager: Eclipse Open Source Components IBM
>> Rational Software: Aurora / GMF / Modeling Tools
>> Phone: 613-270-4613
>>
>> _______________________________________________
>> gmf-dev mailing list
>> gmf-dev@xxxxxxxxxxx
>> https://dev.eclipse.org/mailman/listinfo/gmf-dev
>>
> _______________________________________________
> gmf-dev mailing list
> gmf-dev@xxxxxxxxxxx
> https://dev.eclipse.org/mailman/listinfo/gmf-dev
