OK thanks for clarifying. If it is compiled for JDK 11 then +1 from me.
I would think a bump of minimum JDK version is more a major. Perhaps start HK2 4.x for Jakarta EE 11 work as that will be compiled JDK 21.
Steve
From: Arjan Tijms <arjan.tijms@xxxxxxxxxxx>
Sent: Thursday, October 5, 2023 11:14 AM
To: Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx>
Cc: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Releasing HK2 3.0.5
Sorry are you saying h2 3.x was previously released compiled jdk17?
Hk2 itself is not compiled for JDK17, but for JDK11:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<release>11</release>
</configuration>
</plugin>
The TCK for GlassFish, which includes all the latest HK2 versions, is run with JDK 11 as well to ensure this. You just need the JDK 17 compiler, hence the requirement. It's a thing that came in with the (optional)
Spring module, and its dependencies.
That all said, in one of the issues the team did suggest bumping HK2 to 3.1.x, so this may be a good opportunity.
|