Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] GlassFish 7.0.8 (Mojarra 4.0.3) does not pass the Faces TCK...


On Fri, Sep 8, 2023, 10:52 AM Arjan Tijms <arjan.tijms@xxxxxxxxxxx> wrote:




Thank you!

Wildly passed the new Faces TCK with the staged 4.0.4.  WildFly is still running the old Faces TCK here with the staged 4.0.4.

Scott
On Fri, 8 Sept 2023 at 16:23, Arjan Tijms <arjan.tijms@xxxxxxxxxxx> wrote:
Hi,

With the latest rev of the Mojarra 4.0 branch, and the latest Faces TCK branch, the TCK passes successfully, and failures in either the new (maven) or old (ant) sub-parts of the TCK successfully cause the entire run to fail now:

[...]

[INFO] Jakarta Faces TCK 4.0.3-SNAPSHOT - Test - Faces 4.0 - f:selectItemGroup 4.0.3-SNAPSHOT SUCCESS [ 14.309 s]

[INFO] Jakarta Faces TCK 4.0.3-SNAPSHOT - Test - Faces 4.0 - f:selectItemGroups 4.0.3-SNAPSHOT SUCCESS [ 14.150 s]

[INFO] Jakarta Faces TCK 4.0.3-SNAPSHOT - Test - Faces 4.0 - h:selectManyCheckbox 4.0.3-SNAPSHOT SUCCESS [ 14.624 s]

[INFO] Jakarta Faces TCK 4.0.3-SNAPSHOT - Test - Old TCK Selenium 4.0.3-SNAPSHOT SUCCESS [  0.047 s]

[INFO] Jakarta Faces TCK 4.0.3-SNAPSHOT - Test - Old TCK Port - Ajax 4.0.3-SNAPSHOT SUCCESS [ 15.168 s]

[INFO] Jakarta Faces TCK 4.0.3-SNAPSHOT - Test - Old TCK Port - commandLink 4.0.3-SNAPSHOT SUCCESS [ 15.246 s]

[INFO] Jakarta Faces TCK 4.0.3-SNAPSHOT - Test - Faces 2.2 - protectedViews 4.0.3-SNAPSHOT SUCCESS [ 14.534 s]

[INFO] Old Jakarta Faces TCK - build 4.0.3-SNAPSHOT ....... SUCCESS [01:56 min]

[INFO] Old Jakarta Faces TCK - main 4.0.3-SNAPSHOT ........ SUCCESS [  0.040 s]

[INFO] Old Jakarta Faces TCK - run 4.0.3-SNAPSHOT ......... SUCCESS [  02:25 h]

[INFO] Faces TCK Signature Test 4.0.0 ..................... SUCCESS [ 10.136 s]

[INFO] ------------------------------------------------------------------------

[INFO] BUILD SUCCESS

[INFO] ------------------------------------------------------------------------

[INFO] Total time:  02:39 h



Tested with GlassFish 7.0.9-SNAPSHOT with locally integrated Mojarra 4.0.4-SNAPSHOT on JDK 17.

Kind regards,
Arjan Tijms


On Thu, 7 Sept 2023 at 23:44, Arjan Tijms <arjan.tijms@xxxxxxxxxxx> wrote:
Hi,

I also updated the TCK to 4.0.3 just now, and added directives to fail.

Running the tck locally from the tck folder with

 mvn clean install -Dmojarra.noupdate=true -pl :old-tck-build,:old-tck-run

Will produce the correct failure.

If you already have done the build and/or just want to see the tests fail:

mvn install -Dmojarra.noupdate=true -pl :old-tck-run -Drun.test="com/sun/ts/tests/jsf/api/jakarta_faces/context/facescontextwrapper/URLClient.java"

Kind regards,
Arjan Tijms




On Thu, 7 Sept 2023 at 22:43, Scott Marlow <smarlow@xxxxxxxxxx> wrote:

FYI, the old Faces TCK tests are now passing with a local build of WildFly using Mojarra 4.0.4-SNAPSHOT build from this morning.

The bad news is I see a New Faces TCK failures in ee.jakarta.tck.faces.test.servlet50.ajax.Spec1567IT as per https://gist.github.com/scottmarlow/5bb0cac14c0e6dba7165b921d22f5552, this is also with WildFly and the same local build of Mojarra 4.0.4-SNAPSHOT.

Scott

On 9/6/23 10:20 AM, Arjan Tijms wrote:
Hi,

Indeed, thanks for the notification. The root cause of this slipping through is the Faces TCK (as executed by the Jakarta TCK CI) showing up as green (passed) in the console, yet reporting failures in the old part of the TCK.

We'll work on a fix and hope to release an update soon.

Kind regards,
Arjan Tijms


On Wed, 6 Sept 2023 at 16:17, Scott Marlow via glassfish-dev <glassfish-dev@xxxxxxxxxxx> wrote:
Hi,

We missed a few Faces TCK test failures which are reported via mojarra/issues/5308 [1].  

We are seeing the same TCK failures with WildFly (main branch) as well via WFLY-18397 [2] with Mojarra 4.0.3.

Scott

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev

Back to the top