Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] Omniconcurrent
  • From: "Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>
  • Date: Tue, 21 Jun 2022 08:59:49 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=payara.fish; dmarc=pass action=none header.from=payara.fish; dkim=pass header.d=payara.fish; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9xdV7dwjKz0a4CmqgkaDEjdS8tqIe5/L1b/uUplQM84=; b=kS7nN/0j/dih+aNpbb3bXpFmOjIY+hApGJPXs+FyrPxBxlaaG68xL4Oz7eP4TCaCTurCbiHvn7yLp2GK67B1QvHFZiOyypVRYs290Rag9QOJHeEOaRbcrvospHPbQhyN3UDMlLJbjvnUcQHcZ6iwtjRh4Yy2nD2n7QzVkbHOZnyL4biK7YtxUNYgvEsh68Oq1AwhdsDbQkWaN8RXgDM3DEgKB9K9Qxe0fNMMAFhck54toGI4F5XZRFgCUkEio9PIFu0CXjLN6cxvEIrRMEZ1xBQ2ro8znMFEoEN0IJ1517zhitAtCTZs0oH4i8h7oBAFahDG7xe8PH/9VfwfLC6myQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CGwU3eAHXYaF2NHDOKaLpNw/1UfKUATn5LVJzPwZc0GxGh6wCOjr8GTEmzlv2NyioAadECWjmZf+VgpYHCZf9PW6H78ZBu6bgvDgQK/jBJmaL8KodCN2Xank5TkUeuIxB3DRpYc3HwVHWVuOBAQWYzRwR+7wyAI3bo9gALI6lnbiclPSMSkeIWMbUmNEDeFzDCr+EOcG4FmCLpNeexhh3XV2Njl7xJw0U7LFKAoX0ZfF1UdmpntlybZ9Bwddkdum6jSjNedflaIgvBx299cRQfH2h0rLVGm2J5ymrXtJhHbInDLXRNJofh1jFsEJOa4PAiuAp3M9EqeggXK1noS6wA==
  • Delivered-to: glassfish-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/glassfish-dev/>
  • List-help: <mailto:glassfish-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/glassfish-dev>, <mailto:glassfish-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/glassfish-dev>, <mailto:glassfish-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AQHYhO9hTrnKfQtiW0iw2aA0f3kEn61ZifgAgAABl1A=
  • Thread-topic: [glassfish-dev] Omniconcurrent

Hi Arjan,

 

I emailed in response to the broad request for permission to relicense Payara code that for correct IP flows we would backport the changes. I just noticed the PR to incorporate Omniconcurrent initially was titled “Implement Jakarta Security glue code” until yesterday and has a whole raft of changes to different code in it, probably why I missed it.

 

So are we still doing the work to port the Payara changes or is the alternative working?

 

Steve

 

 

 

From: glassfish-dev <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of arjan tijms
Sent: 21 June 2022 09:36
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Omniconcurrent

 

Hi Steve,

 

Please accept my humble apologies for if anything wasn't clear. I was just about to write an email to the list, but it's been hectic with so many things going on and asking for attention.

 

There has been no duplicate work luckily. The OmniConcurrent lib is just the alternative approach I mentioned I was working on during the platform call. The PR had been open for 3 days, and a diverse set of reviewers from different companies was tagged. 

 

The other PR with the Payara code was open for even longer (8 days) and didn't get any response. I think both the PRs and the mailing list are important vehicles for discussion, so the PR could have solicited at least some discussion. That PR was ready to go in, no duplication of effort was required by the Payara team. See https://github.com/eclipse-ee4j/glassfish/pull/23989  It could either be given permission, or copied fully and then sent back as a PR (so that the PR would be fully under Payara's name). I sent an e-mail about that to Payara, suggesting exactly that 9 days ago.

 

In the discussion on the platform mailing list the ask to give permission for much of the glue code didn't get much of a response either, and the much smaller PR for just the CDI extension (that would benefit Concurrency RI anyway, even without GlassFish in the equation) already seemed somewhat controversial.

 

That all said, as mentioned there's no duplication really, as it would still be better to have all the code directly in GlassFish under the EPL. The OmniConcurrent lib is just the backup solution here. It could be just enough to get to ballot, and then at a time and pace that is convenient for everyone it can be replaced. Additionally note that the appserver/concurrent package has not been deleted from GlassFish. This was done exactly for this reason.

 

Hope this all makes it more clear.

 

Kind regards,

Arjan Tijms

 

 

 

 

 

 

 

 

 

 

On Mon, Jun 20, 2022 at 11:48 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

I've seen a PR bringing in "Omniconcurrent" which seems to contain bits of Payara code. There has been zero discussion on this list of what that is or that that was an approach we were following. Last I heard Payara team were going to backport Payara code to GlassFish. If that isn't the case Payara team can stop duplicating effort and get on with something else.

 

Can people communicate on this list on major dev decisions impacting others.

 

Steve

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev


Back to the top