Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
[glassfish-dev] PRs and reviews
  • From: "Steve Millidge (Payara)" <steve.millidge@xxxxxxxxxxx>
  • Date: Thu, 19 May 2022 11:13:20 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=payara.fish; dmarc=pass action=none header.from=payara.fish; dkim=pass header.d=payara.fish; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/T3Ip/wKNAcvTqFpXwlyefqXUTGeFuQTBru2wNLknLQ=; b=ft/axUfjSozv0LtBIW4Qd95BTm+YDGh51oRNU4Pwi1OMswYKh6QwiFtZZUwvOMYNAJUZ8H8g9JxxYwN0UQs8wf6ZCZPLyOHFED1f8z/2/VrD7n08S+LqQmvNFgyJwF95QlPgrHx9KU1vcOL1RA06pomEEG05uJuc8fKGhVV9RFa1iuNtxOUnEFQNqMnSB8MpnNd6apkAou6X+Qo3DyMTQx77HdujR1dqpZQU6PbwCjLZu8ILZbv1deDFEKPyJXUMi4/MbfuusPWLciUxnGROCB3mfWBGDiD3cJDXcN/XB3SQkOk++D13030bb16BqDOYUwhWZhm8tKKZphxipwjW4w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MoigIruiz+DkooYG/5Zw3uD8XiTszeNKAEdXD56Fhft0l+VmD+aEEducltD/c8ZrgG4pIZUcdH8eLDh+xyLL5JUxzplEYNsdQCu3tpXLyZMfKTa8RxFSJbmKPPxb53E0hX0PuU24RW7R5/h64tbSsfIrhiINveVaWMssYwUqW68zuPmmjVNF7p/PbP5aQ9LV1EYr766DiwLH+SZVaT9DxA2Zu7J8c6PjhqH0LTEDp2pQn50ujGUEnp9lPRKT6QWJQvSZuX97JVZEOEq8LdwUcHmk1S3cQpHk7XKL8R+RwzgNmEvalIYvAKIkmLrmULo9QCgJuc4VEGI2EcTIAQ6Hrw==
  • Delivered-to: glassfish-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/glassfish-dev/>
  • List-help: <mailto:glassfish-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/glassfish-dev>, <mailto:glassfish-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/glassfish-dev>, <mailto:glassfish-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: AdhrcNg1pKho9Mj3RaC7IoIHuQyNBQ==
  • Thread-topic: PRs and reviews

Hi,

 

I know people are working rapidly to achieve the GlassFish 7.0.0 release for Jakarta EE 10. However post the 7 release we need to ensure that PRs when raised have a broad set of reviewers. Currently many PRs are being raised, solely requested  for review by a committer from the same company, then merged and closed all within a very short time. This does not enable a plurality of views to be taken into account. I think this is fine as new EE 10 apis are merged in. However beyond the EE 10 release I believe issues should be raised and reviews requested by members of the team from a different organisation. Happy to have some rules on lazy consensus to not slow everybody up. This should encompass all repositories within the GlassFish project.

 

Thanks

 

Steve Millidge

 

 

Back to the top