Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] AppClient Failures
Great 

Thank you Alwin and Hussain.
I am just middle of  updating the GF but Hussain already did :)

On 21 Aug 2020 Fri at 08:24 <Hussain.NM@xxxxxxxxxxxxx> wrote:

I have created a pull request https://github.com/eclipse-ee4j/glassfish/pull/23187 to use the latest Jakarta EE schema and version for the following schemas:

 

·       application

·       application-client

·       connector

·       ejb-jar

·       web-app

·       webservices

·       permissions

 

Thanks

Hussain

 

From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Alwin Joseph
Sent: Friday, August 21, 2020 9:55 AM
To: Gurkan Erdogdu <cgurkanerdogdu@xxxxxxxxx>
Cc: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] AppClient Failures

Hi Gurkan,

I created https://github.com/eclipse-ee4j/jakartaee-tck/pull/465 to fix the appclient tests. Looks like the last update was missing the "metadata-complete" attribute.
The tests do pass with this tck change. At least to pass these tests there is no change required from glassfish side.

Regards,
Alwin

On 21/08/20 3:12 am, Gurkan Erdogdu wrote:

I think we need to update the code in com.sun.enterprise.deployment.node.appclient.AppClientNode#initSystemIDs to add version 9.

+1

 

 

On Fri, Aug 21, 2020 at 12:34 AM Gurkan Erdogdu <cgurkanerdogdu@xxxxxxxxx> wrote:

Hi Alwin

As you mentioned, I have updated application-client.xml with the

 

<application-client version="8" metadata-complete="true" xmlns="http://xmlns.jcp.org/xml/ns/javaee"
                    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                    xsi:schemaLocation="http://xmlns.jcp.org/xml/ns/javaee http://xmlns.jcp.org/xml/ns/javaee/application-client_8.xsd">

 

And all of the tests are passed

Correct. This was the old schema. https://jakarta.ee/xml/ns/jakartaee is the new one.

 

I think we need to update some parsing source code in GF codebase

Regards.

Gurkan

 

On Thu, Aug 20, 2020 at 9:25 PM Gurkan Erdogdu <cgurkanerdogdu@xxxxxxxxx> wrote:

Thanks for the update.

 

On 20 Aug 2020 Thu at 21:24 Alwin Joseph <alwin.joseph@xxxxxxxxxx> wrote:

Hi Gurkan,

I suspect this is due to the schema updates in the tck files made recently.
src/com/sun/ts/tests/appclient/deploy/metadatacomplete/testapp/application-client.xml
src/com/sun/ts/tests/appclient/deploy/metadatacomplete/testapp/application.xml

I will revert back this change if I confirm this.

Regards,
Alwin

On 20/08/20 1:15 pm, Gurkan Erdogdu wrote:

Hi

 

I debugged the code and it throws deployment exception in ApplicationClientDescriptor#getResourceDescriptors in switch case CFD

 

Any idea?

 

    @Override
    public Set<ResourceDescriptor> getResourceDescriptors(JavaEEResourceType type) {
        switch(type) {
            case CFD:
                throw new UnsupportedOperationException(localStrings.getLocalString(
                            "enterprise.deployment.exceptionappclientnotsupportconnectionfactorydefinition",
                            "The application client [{0}] do not support connection factory definitions",
                                new Object[] {getName()}));
            case AODD:
                throw new UnsupportedOperationException(localStrings.getLocalString(
                            "enterprise.deployment.exceptionappclientnotsupportadministeredobjectdefinition",
                            "The application client [{0}] do not support administered object definitions",
                                new Object[] {getName()}));

        }
        return super.getResourceDescriptors(type);
    }



--



--



--

This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored. This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev
--
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com

Back to the top