Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] Github Commit Problem
I have also checked that I am not able to do anything in GF Github (for example : not able to close/edit issues)

On Fri, Jul 17, 2020 at 3:39 PM Gurkan Erdogdu <cgurkanerdogdu@xxxxxxxxx> wrote:
Then, is it normal not to push to the repository? Committers can only merge?

On Fri, Jul 17, 2020 at 3:36 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

We work this way to give opportunity for review as there are many people working on the project also PRs are built and  tested via Jenkins to add a level of confidence before merging.

 

As a committer you can merge PRs, and close issues. For master you can’t merge a PR that has zero approving reviews.

For branches you can merge PRs without review.

 

Committers can also close issues.

 

Steve

 

From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Gurkan Erdogdu
Sent: 17 July 2020 13:32
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Github Commit Problem

 

There are branch protections on master you have to raise a PR. You shouldn’t really be pushing direct to branches without going via your fork.

I see.

But, why is working this way?

Is it possible to remove this protection? I think we can move to CTR status to improve the process.

I know that the process is very slow especially on branches but if I work on the branch, I can commit every day for simple features.

Regards.

Gurkan

 

On Fri, Jul 17, 2020 at 3:27 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

There are branch protections on master you have to raise a PR. You shouldn’t really be pushing direct to branches without going via your fork.

 

From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Gurkan Erdogdu
Sent: 17 July 2020 13:19
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Github Commit Problem

 

Hi Steve

I am trying to push the code to the GF repository. Because I am now a committer, I must able to commit and push the code but not able to do.

Regards.

Gurkan

 

On Fri, Jul 17, 2020 at 2:57 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

What are you trying to do?

From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> on behalf of Gurkan Erdogdu <cgurkanerdogdu@xxxxxxxxx>
Sent: Friday, July 17, 2020 12:38:53 PM
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: Re: [glassfish-dev] Github Commit Problem

 

My email in my GitHub Profile is the same as Eclipse account (cgurkanerdogdu@gmail) but still receive the error

 

remote: Permission to eclipse-ee4j/glassfish.git denied to gerdogdu.
fatal: unable to access 'https://github.com/eclipse-ee4j/glassfish.git/': The requested URL returned error: 403

 

Do I need to be a member of eclipse-ee4j organization in Github?

 

On Fri, Jul 17, 2020 at 2:06 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

You need to ensure your GitHub credentials are associated with your Eclipse account in the profile section.

 

Steve

 

From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Gurkan Erdogdu
Sent: 17 July 2020 11:14
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: [glassfish-dev] Github Commit Problem

 

Hi folks

As I am now the committer for the GF project, I was trying to commit via my github credentials, but it was rejected.  Is there anything I need to configure?

Regards.

Gurkan

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev



--

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev



--

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev



--

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev


--


--
Gurkan Erdogdu
http://gurkanerdogdu.blogspot.com

Back to the top