Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [glassfish-dev] Github Commit Problem
Hi, 

Anyone can submit a PR, but only committers can merge them...

Ivar

On Fri, Jul 17, 2020 at 2:29 PM Gurkan Erdogdu <cgurkanerdogdu@xxxxxxxxx> wrote:
Ivar
Yes, I understand that but at the moment I am committing a very small thing (just chaning JDK 1.5 to 1.8 in one pom file) to just confirm that my commits are gone through correctly.
Also, I am concerned about working via this way. Then, what is the idea of becoming a committer? Anyone can just push PR.

Regards.
Gurkan


On Fri, Jul 17, 2020 at 3:26 PM Ivar Grimstad <ivar.grimstad@xxxxxxxxxxxxxxxxxxxxxx> wrote:
One thing though. I am not sure how the process for committing to the GlassFish project is. 
Usually, I think contributions are made by submitting a PR so others can review changes before merging. 
Committing directly without anyone's review is normally pretty rare. 

Ivar

On Fri, Jul 17, 2020 at 2:20 PM Ivar Grimstad <ivar.grimstad@xxxxxxxxxxxxxxxxxxxxxx> wrote:
Open a ticket in Bugzilla, https://bugs.eclipse.org/bugs/

Ivar

On Fri, Jul 17, 2020 at 2:16 PM Gurkan Erdogdu <cgurkanerdogdu@xxxxxxxxx> wrote:
Thanks Jorge.
Do I need to open a ticket in Glassfish project or some other ?
Regards.
Gurkan

On Fri, Jul 17, 2020 at 3:09 PM Jorge Bescos <jorge.bescos.gascon@xxxxxxxxxx> wrote:

Hello Gurkan,

I had the same issue, I opened a bug here and they solved it:

https://bugs.eclipse.org/bugs/

As you pointed out, you need to be member of eclipse-ee4j.

Jorge

On 2020-07-17 13:38, Gurkan Erdogdu wrote:
My email in my GitHub Profile is the same as Eclipse account (cgurkanerdogdu@gmail) but still receive the error

remote: Permission to eclipse-ee4j/glassfish.git denied to gerdogdu.
fatal: unable to access 'https://github.com/eclipse-ee4j/glassfish.git/': The requested URL returned error: 403

Do I need to be a member of eclipse-ee4j organization in Github?

On Fri, Jul 17, 2020 at 2:06 PM Steve Millidge (Payara) <steve.millidge@xxxxxxxxxxx> wrote:

You need to ensure your GitHub credentials are associated with your Eclipse account in the profile section.

 

Steve

 

From: glassfish-dev-bounces@xxxxxxxxxxx <glassfish-dev-bounces@xxxxxxxxxxx> On Behalf Of Gurkan Erdogdu
Sent: 17 July 2020 11:14
To: glassfish developer discussions <glassfish-dev@xxxxxxxxxxx>
Subject: [glassfish-dev] Github Commit Problem

 

Hi folks

As I am now the committer for the GF project, I was trying to commit via my github credentials, but it was rejected.  Is there anything I need to configure?

Regards.

Gurkan

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev


-- 

_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://urldefense.com/v3/__https://www.eclipse.org/mailman/listinfo/glassfish-dev__;!!GqivPVa7Brio!LgiAyHNFh2wTj__hQe18fcshOOWJ7DE4zKDzlEpcrDa5o-fVXXPzcFz928I3Cs83-u2-fDU$
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev


--
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev


--

Ivar Grimstad

Jakarta EE Developer Advocate | Eclipse Foundation, Inc.

Community. Code. Collaboration. 

Join us at our virtual event: EclipseCon 2020 - October 20-22


--

Ivar Grimstad

Jakarta EE Developer Advocate | Eclipse Foundation, Inc.

Community. Code. Collaboration. 

Join us at our virtual event: EclipseCon 2020 - October 20-22
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev


--
_______________________________________________
glassfish-dev mailing list
glassfish-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/glassfish-dev


--

Ivar Grimstad

Jakarta EE Developer Advocate | Eclipse Foundation, Inc.

Community. Code. Collaboration. 

Join us at our virtual event: EclipseCon 2020 - October 20-22

Back to the top