Re: [glassfish-dev] test failures

[arjan tijms <arjan.tijms@xxxxxxxxx>]

Hi Romain,

Thanks for doing the revert for me!

I have a good idea now what might have gone wrong with the code and will prepare a new PR. 

Kind regards,

Arjan

On Tue, Dec 4, 2018 at 1:49 AM Romain Grecourt <romain.grecourt@xxxxxxxxxx> wrote:

On 12/3/18 12:22 PM, arjan tijms wrote:

Hi,

I just saw it's published in Maven central indeed, so maybe it was just a temp hiccup when I tried the build first :O

Kind reminder, the source of truth is the pipeline not our local environments.
FYI I did revert the PR and the build of EE4J_8 branch is back to normal (clean test results).

On Mon, Dec 3, 2018 at 9:13 PM arjan tijms <arjan.tijms@xxxxxxxxx> wrote:

Hi Romain,

It could well be that I did something wrong, but before the commit the branch didn't even build. It referred to Mojarra 2.3.3.102, which doesn't seem to be published anywhere (at least not in a location known by GF).

So I'm a little puzzled how the failures can be new ones. Do you know how GF was able to build before that PR? Where did it get Mojarra 2.3.3.102 from?

Kind regards,

Arjan

On Mon, Dec 3, 2018 at 9:03 PM Romain Grecourt <romain.grecourt@xxxxxxxxxx> wrote:

Hi,

PR #22644 has been merged with test failures. See [1] and [2]

This is impact every other pull requests for the EE4J_8 branch.
I'm going to revert the corresponding commit(s).

Thanks,
Romain


[1] https://github.com/eclipse-ee4j/glassfish/pull/22644
[2]
https://jenkins.eclipse.org/glassfish/blue/organizations/jenkins/glassfish/detail/PR-22644/2/