Re: [faces-dev] Faces 4.1 TCK enforces Java 21 requirement

[Paul Nicolucci <pnicolucci@xxxxxxxxx>]

Hi,

I've created a PR: https://github.com/jakartaee/faces/pull/1898

Thanks,

Paul Nicolucci

On Wed, Feb 21, 2024 at 1:59 PM Arjan Tijms <arjan.tijms@xxxxxxxxxxx> wrote:

Hi,

The enforcement should actually (for now) be in the GlassFish profile. It was put in the wrong place I think.

Kind regards,

Arjan Tijms

On Wed, 21 Feb 2024 at 19:36, Paul Nicolucci via faces-dev <faces-dev@xxxxxxxxxxx> wrote:

Hi,

I was looking over some of the Faces 4.1 changes and came across the following:  https://github.com/jakartaee/faces/blob/4.1/tck/pom.xml#L373

Commit: https://github.com/jakartaee/faces/commit/f15a8baeef1ca4e4ee3ac563b819691803ca9b0b

        <plugins>
            <plugin>
                <artifactId>maven-enforcer-plugin</artifactId>
                <configuration>
                    <rules>
                        <requireMavenVersion>
                            <version>3.6.3</version>
                        </requireMavenVersion>
                        <requireJavaVersion>
                            <version>21</version>
                        </requireJavaVersion>
                    </rules>
                </configuration>
                <executions>
                    <execution>
                        <goals>
                            <goal>enforce</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>

Since the TCK should be able to be used to certify with Java 17 and Java 21 shouldn't we reduce this down to Java 17?

If no objection I can get a PR up to change this to Java 17.

Thanks,

Paul Nicolucci

_______________________________________________
faces-dev mailing list
faces-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/faces-dev