Re: [equinox-dev] Perform Freeze Periode Verification as dedicated GitHu

[Sravan K Lakkimsetti <sravankumarl@xxxxxxxxxx>]

Hi,

 

This is a very good idea. Please go ahead with the workflow implementation in g.c/eclipse-platform/eclipse.platform.releng.

 

By the way, the calendar is publicly available. https://calendar.google.com/calendar/u/0?cid=cHJmazI2ZmRtcHJ1MW1wdGxiMDZwMGpoNHNAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ you can read the calendar here

 

Thanks

Sravan

 

From: equinox-dev <equinox-dev-bounces@xxxxxxxxxxx> On Behalf Of Hannes Wellmann
Sent: 05 April 2022 00:28
To: Eclipse platform general developers list. <platform-dev@xxxxxxxxxxx>; platform-releng-dev@xxxxxxxxxxx; equinox-dev@xxxxxxxxxxx; pde-dev@xxxxxxxxxxx
Subject: [EXTERNAL] [equinox-dev] Perform Freeze Periode Verification as dedicated GitHub workflow

 

For Platform-Projects hosted on GitHub the Freeze-Period-Check for PRs is currently performed as last step of the verification build-pipeline on Jenkins. This has the disadvantage that in case the freeze period is active and the build therefore fails, the cause of the failure is not directly obvious.

 

Therefore I want to suggest to run the freeze-period-check in a dedicated GH action workflow.

The freeze-period check would then appear as separate check in the "checks-overview" of a PR.

 

The workflow could be implemented as a reusable workflow [1] that is for example defined in the g.c/eclipse-platform/eclipse.platform.releng or eclipse-platform/eclipse.platform.releng.buildtools repo. The workflow could then be called by all other Eclipse repos that have to run this check.

Because the workflow is only defined once it could also be considered to avoid the use of the "verifyfreezeperiod.sh" script and to implement the logic directly into the workflow.

 

In case the check requires credentials to log into the calendar, which at least the mentioned script does, then the secrets could be stored in GitHub's secret store at organization level ([2] and [3]).
But I actually expected the calendar could be publicly available for read.

 

If you others are interested I could set up a corresponding workflow.

 

[1] - https://docs.github.com/en/actions/using-workflows/reusing-workflows

[2] - https://docs.github.com/en/actions/security-guides/encrypted-secrets

[3] - https://github.blog/changelog/2020-05-14-organization-secrets/