Re: [epp-dev] Broken Recommenders News Feed with Java 11

[Gunnar Wagenknecht <gunnar@xxxxxxxxxxxxxxx>]

Hi Andreas,

Thanks for the pointers, I merged the review.

I ran into another issue with Java 11 today. I may look like AERI is broken, too.

javax.annotation.PostConstruct cannot be found by org.eclipse.recommenders.rcp_2.5.4.v20180909-1132

at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:511)

at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:422)

at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:414)

at org.eclipse.osgi.internal.loader.ModuleClassLoader.loadClass(ModuleClassLoader.java:153)

at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)

at org.eclipse.recommenders.internal.rcp.RcpModule$Listener$1.afterInjection(RcpModule.java:278)

Are you aware of anything like that? Should I open a bug for investigation?

-Gunnar

-- 
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx, http://guw.io/

On Nov 20, 2018, at 09:35, Andreas Sewe <andreas.sewe@xxxxxxxxxxxxxx> wrote:

Hi Gunnar,

There are two Java 11 issues:
https://bugs.eclipse.org/539545
https://bugs.eclipse.org/539681

It may be just one.

yes, Bug 539681 in Mylyn Commons is the root cause, but I haven't heard
back from the Mylyn maintainers. And moving the news plugin to some
other feed parsing library (which we would need a CQ for) is not
something I have time for right now, so fixing this upstream in Mylyn
Commons would be my preferred solution.

I wonder if anyone knows if there is anyone working
on a solution? It looks like the correct approach would be to use import
package and include the jaxb bundle from Orbit but only resolve it on
Java 11. I'm not sure if that works. Should we disable the recommenders
newsfeed meanwhile to prevent the bad experience for users?

I have created [1] a while back to disable it for now, before going on
vacation. Looks like the Gerrit change [2] still hasn't been merged. (As
this affects not just the Java package I maintain but also the
committers package, I've added Markus Knauer as a co-reviewer in Gerrit.)

So, yes, IMHO we should disable it for now.

Best wishes,

Andreas

[1] <https://bugs.eclipse.org/bugs/show_bug.cgi?id=540196>
[2] <https://git.eclipse.org/r/#/c/131008/>

--
Codetrails GmbH
The best code possible

Robert-Bosch-Str. 7, 64293 Darmstadt
Mobile: +49-170-811-3791
http://www.codetrails.com/

Managing Director: Dr. Marcel Bruch
Handelsregister: Darmstadt HRB 91940