[emfcp-dev] Warnings

[Jonas Helming <jonas.helming@xxxxxxxxxxxxxx>]

Hi,

unfortunately we have many warnings in our code. I don't think anyone 
disagrees that this is not good. I actually had a look at many 
instances. There is a very large number of warnings, which are caused by 
only a few causes, e.g. package visibility or missing x-friends. 
However, I also found several warnings, which could potentially be 
crucial. So it is not for cosmetic reasons, it is about stability.

I will try to remove the causes for the majority of warnings to get a 
clearer picture and create BRs for other ones. Eike has also started to 
do this for the SPI. After that I will record the current count and 
observe it.
So the first thing I want to set as a rule: No commit introduces new 
warnings. I will check this on a weekly basis. Violators owe me a beer 
per warning :-)
If you remove warnings, please use this BR: 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=412348
Please also use the BR to discuss in case you are not sure about how to 
resolve warnings.


Cheers

Jonas