Re: [ejb-dev] Need reviews on open PRs

[Edwin Derks <ederks85@xxxxxxxxx>]

Hi Hussain,

I have taken a look at #106 and #109, and approved them. The changes make sense and look good to me. I have posted one question regarding the usage of the RC and M releases in the pom.xml. Just curious if this is desired or not, but could be a perfectly valid case.

Hope this helps,

Edwin

On Tue, 23 Jun 2020 at 07:50, <Hussain.NM@xxxxxxxxxxxxx> wrote:

Thanks Ed.

 

From: Ed Bratt <ed.bratt@xxxxxxxxxx>
Sent: Tuesday, June 23, 2020 11:12 AM
To: ejb developer discussions <ejb-dev@xxxxxxxxxxx>; N M, Hussain (Cognizant) <Hussain.NM@xxxxxxxxxxxxx>
Subject: Re: [ejb-dev] Need reviews on open PRs

 

I approved and merged the first two. I don't feel qualified to approve 106 or 109.

On 6/22/2020 9:30 PM, Hussain.NM@xxxxxxxxxxxxx wrote:

Please review the following PRs:

 

#105 – 4.0.0-RC2

-        Straight-forward merge of 4.0.0-RC2 branch into master.

-        The ECA is failing due to ejb-bot. After merging please delete the following branches:

o   4.0.0-RC1

o   4.0.0-RC2

 

#103 – Replace PNG images with SVG

-        All PNG images are re-created into SVG format on a best-effort basis.

-        One bug fix is included – inline image changed to block image in few places which I missed earlier.

 

#106 – Fix Javadoc warnings

-        Removed the doclint none option from maven-javadoc-configuration and cleaned up all the javadoc errors and warning.

-        Generic @param and @return description is added where it was missing earlier. This can be improved in a future PR.

 

#109 – Cleanup pom

-        Updated plugins to latest version

-        From parent project “mvn clean install” will generate a zip file with apidocs and specification documents.

A new job in Jenkins needs to be created to generate the above artifact. This can be used as source for raising PR in jakartaee/specifications

-        The parent tag is removed from both root and spec projects (these projects are not meant to be published to maven central so there is no need for ee4j-parent)

-        The groupId and artifactId of root and spec projects is made consistent with api project. There is no impact of this change since the root and spec projects are not published.

-        Added project information such as organization, scm, issueManagement and mailingList

-        Added EFSL 1.0 license in root and spec pom

-        Change findbugs-maven-plugin to spotbugs-maven-plugin

-        Fix “mvn site” in api project. Added spotbugs and Javadoc to site.

 

Let me know if any changes are required.

 

Thanks

Hussain

 

This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored. This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.

_______________________________________________

ejb-dev mailing list

ejb-dev@xxxxxxxxxxx

To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/ejb-dev

This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored. This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored.

_______________________________________________
ejb-dev mailing list
ejb-dev@xxxxxxxxxxx
To unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/ejb-dev