Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ejb-dev] Request for review on PR# 74 and 75

I reviewed PR #74 yesterday and it looks great.  Looking at PR #75 this morning.  But, since neither myself or Hussain have write access to this repo, we need some assistance to get these merged.  Can we get a quick review, approval, and merge from someone on the EJB team?  Thanks!

---------------------------------------------------
Kevin Sutter
STSM, MicroProfile and Jakarta EE architect @ IBM
e-mail:  sutter@xxxxxxxxxx     Twitter:  @kwsutter
phone: tl-553-3620 (office), 507-253-3620 (office)    
LinkedIn:
https://www.linkedin.com/in/kevinwsutter



From:        <Hussain.NM@xxxxxxxxxxxxx>
To:        <ejb-dev@xxxxxxxxxxx>
Date:        02/29/2020 23:14
Subject:        [EXTERNAL] [ejb-dev] Request for review on PR# 74 and 75
Sent by:        ejb-dev-bounces@xxxxxxxxxxx




I took a stab at formatting the specification document. I selected chapter 11 Enterprise Bean Environment and made the following changes:
  • Change italics to monospace for keywords
  • Change link to xref
  • Move anchors before section heading
  • Add source block for code
  • Change header level for subsections
  • Add monospace for keywords
  • Change curly quotes to straight quotes
  • Add ordered and numbered list where applicable
  • Added footnotes
Attached the diff for PR# 74

The second PR is for chapter 20 Related Documents. I have converted the custom ID into bibliography with custom label which displays the number. This is done to match with the existing document.

Attached the diff for PR# 75

Please review and let me know if any changes are required.

Thanks
Hussain
This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored. This e-mail and any files transmitted with it are for the sole use of the intended recipient(s) and may contain confidential and privileged information. If you are not the intended recipient(s), please reply to the sender and destroy all copies of the original message. Any unauthorized review, use, disclosure, dissemination, forwarding, printing or copying of this email, and/or any action taken in reliance on the contents of this e-mail is strictly prohibited and may be unlawful. Where permitted by applicable law, this e-mail and other e-mail communications sent to and from Cognizant e-mail addresses may be monitored. [attachment "pr74.patch" deleted by Kevin Sutter/Rochester/IBM] [attachment "pr75.patch" deleted by Kevin Sutter/Rochester/IBM] _______________________________________________
ejb-dev mailing list
ejb-dev@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/ejb-dev




Back to the top