| Re: [ejb-dev] API updates for 4.0 |
It all looks good to me. The generics part I am not sure about as honestly it is not familiar territory. Someone else should really take the time to help you analyze that. I had spent a bunch of time in the Java EE 8 time frame analyzing the repeatable annotations situation. Without going into a possibly unnecessarily long discussion I ultimately drew the same conclusions. I would hit the approve button for you but honestly my paperwork situation is still murky. I am still hoping I can sort it out. Maybe someone else can oblige? As far as I can tell, it looks pretty straightforward. Obviously the corresponding TCK tests will need to be removed. I think its fine to leave the actual implementation code as is. Did we ever get the specification documents? Presumably those will need to change too. Lastly, let me know when it's done and ready to be tested. That should be an easy thing most people out there should be able to do. It will make a neat little blog entry too which I will be happy to do if no one else will. Reza Rahman Jakarta EE Ambassador, Author, Blogger, Speaker Please note views expressed here are my own as an individual community member and do not reflect the views of my employer. Sent via the Samsung Galaxy S7, an AT&T 4G LTE smartphone -------- Original message -------- From: David Blevins <dblevins@xxxxxxxxxxxxx> Date: 2/13/20 3:47 AM (GMT+00:00) To: ejb developer discussions <ejb-dev@xxxxxxxxxxx> Subject: [ejb-dev] API updates for 4.0 - https://github.com/eclipse-ee4j/ejb-api/pull/66 Additional things we need: - review if there are any generics we may need/want to add - review if any annotations need to be marked repeatable - switch to the `jakarta` packages for depdendencies I did one of the repeatable annotations. There may be others. -- David Blevins http://twitter.com/dblevins http://www.tomitribe.com |