Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r
  • From: "KARR, DAVID" <dk068x@xxxxxxx>
  • Date: Sat, 8 Feb 2025 17:07:24 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=att.com; dmarc=pass action=none header.from=att.com; dkim=pass header.d=att.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9QB3inVkOGxVOM+R5286miTy9/0p1jJO9wUcbiX+o5M=; b=FcP9gulfHQ31Jgz9K92/YTR19a6xh/tylxvz+65P/L+MhdmGTbgFamfFFkwOJ12F3X0LXFmqxDTro4OccpQN7m3BW1Tc0H156+SlbETX1HKsZlX4mF0wYPbNPp+QlymvFWwhR5zSoXKhM7a85kO4XD/8AMgFPAaSDRwinCn8PpSlCcUZefQcFLKLkt4aAoxkdhL/RoRzCUN5RTI/bHscQGLbx5bfkiY8nuC65qvYA93MeR+LsdlKykaAJymMYE1wLI1Zc9+KpiFx2i3Ac+MMGzXg6DLd37JfKfkxcTUD+vmnxcgVtQbsCeuXyRbcZjEolp8wIo/iMDU0YMjSSCo54A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=xHpwKoXmtYxUl0Fndq9xTV7imTvKWzNPGmYl7zwsJNlDi941rfT1A88E56FEJeWC5a+zVwgeb07XBQ8BJEFhvfJW6p/aMTLHGMMnSgWZ7eGU5zE2FpZHdN668GLKGy6VHOBfupA+E40BSYVU71MeYRvBMXXpFkKQMgUSBB77E+yi3xwopBR0DoUMZwL1StIGD//yJh1qX+jy19OFfCvIb56KFd140fKCdTJrvxFqsluFCFEhW8zpwgCjPSHPyasxJOyQpc/yVrSK9tgatw3Ci//I/oMFPPa/3koYwCZSURSkW88cjgH1YwxCFi+iCmgAJ+12msC6LxDjntGFL5FxFw==
  • Delivered-to: egit-dev@xxxxxxxxxxx
  • List-archive: <https://www.eclipse.org/mailman/private/egit-dev/>
  • List-help: <mailto:egit-dev-request@eclipse.org?subject=help>
  • List-subscribe: <https://www.eclipse.org/mailman/listinfo/egit-dev>, <mailto:egit-dev-request@eclipse.org?subject=subscribe>
  • List-unsubscribe: <https://www.eclipse.org/mailman/options/egit-dev>, <mailto:egit-dev-request@eclipse.org?subject=unsubscribe>
  • Thread-index: Adt5hN1guWAWdSVaTgCc9qwiBw05+gADsWoAAC3ky7A=
  • Thread-topic: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r

(I would post after, but Outlook is being a pain.)

 

I don’t understand what you are saying. Perhaps there’s one point I made that is not completely clear. This hook is working perfectly fine in recent versions of Eclipse on Windows. That means it is working with JGit on Windows.  What is not working is doing the same thing in Anypoint studio on Windows, which uses that old version of Egit.

 

From: Matthias Sohn <matthias.sohn@xxxxxxxxx>
Sent: Friday, February 7, 2025 11:08 AM
To: EGit developer discussion <egit-dev@xxxxxxxxxxx>
Cc: KARR, DAVID <dk068x@xxxxxxx>
Subject: Re: [egit-dev] Investigating an issue with git hooks in egit version 6.5.0.202303070854-r

 

On Fri, Feb 7, 2025 at 6: 41 PM KARR, DAVID via egit-dev <egit-dev@ eclipse. org> wrote: I've been working on a local git hook to perform certain validations. It is working fine with the git command line and with recent versions of Eclipse. 

On Fri, Feb 7, 2025 at 6:41 PM KARR, DAVID via egit-dev <egit-dev@xxxxxxxxxxx> wrote:

I've been working on a local git hook to perform certain validations.  It is working fine with the git command line and with recent versions of Eclipse.  I'm working with a user who is using the Mulesoft Anypoint Studio on Windows, which uses older versions of the Eclipse platform.  This is using version 6.5.0.202303070854-r of eGit.

My git hook is set up with a tiny bash script in C:\Users\<userid>\.githooks\commit-msg .  That one-line script just executes the native application I constructed. The "hooksPath" property is set in the user's .gitconfig file.  The application also looks for debug properties in .gitconfig to write to a log file. Again, this is all working fine with git on the command line, including the log file.

When this user tries to create a commit from Anypoint Studio that is invalid according to the code in the git hook, it lets the commit proceed. Nothing appears in the log file for the hook. When he does this from the git command line, it properly blocks it.

We have verified in Preferences in Studio that it thinks the user's git configuration is in the location we expect, and it has all the properties we expect.

Is it possible that this old version of eGit (released almost two years ago) is doing something different to check the user's .gitconfig and executing hooks?

 

Running the hooks via FS.runHookIfPresent() in JGit is currently only implemented in FS_Posix

This means there is no implementation for Windows yet.

 

 

Contributions are welcome :-)

 

-Matthias

Back to the top