Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Build issues, Bad compile registered as success

2012/4/29 Robin Rosenberg <robin.rosenberg@xxxxxxxxxx>

This build fooled me. Yea I should have run all the tests myself, but apparently I forgot when
the tricky one was resolved.

See https://hudson.eclipse.org/sandbox/job/egit.gerrit/2872/console which skips most of the tests.

the egit.gerrit build job on sandbox hudson does the following build steps:

- run the egit build skipping UI tests (they tend to fail once in a while so we run them separately)
- run the EGit UI tests with maven option "--fail-never" this has the effect that failing UI tests
  mark the change as "UNSTABLE" instead of "FAILED"
- run the EGit Mylyn UI tests with maven option "--fail-never"

in the build you are referencing above the second build step failed since it was unable to resolve
jgit.junit:

[INFO] [Software being installed: org.eclipse.egit.ui.test 2.0.0.qualifier, Missing requirement: org.eclipse.egit.ui.test 2.0.0.qualifier requires 'package org.eclipse.jgit.junit.http [2.0.0,2.1.0)' but it could not be found]
 
this prevented that UI tests were started, it seems the gerrit trigger plugin didn't notice this
so there was no negative vote on this change. If UI tests would have been run and at least
one UI test would fail the change would get a "UNSTABLE" vote. It seems if UI tests can't start
at all this goes unnoticed and gerrit trigger votes +1 which is clearly wrong in this case.

Any idea how to prevent this ? We could run everything in one go but this would mean that
we see -1 vote from Hudson more frequently if there are instable UI tests. If we don't find a
way to close the gap you discovered we should probably go for this solution.

I don't know if another problem is related: https://git.eclipse.org/r/#/c/4617/ passed Verified
from Gerrit, but failed after merge.

this JGit build failed since connection to maven central timed out:

[WARNING] Could not transfer metadata org.hamcrest:hamcrest-library/maven-metadata.xml from/to central (http://repo1.maven.org/maven2): Error transferring file: Connection timed out[WARNING] Could not transfer metadata org.hamcrest:hamcrest-library/maven-metadata.xml from/to central (http://repo1.maven.org/maven2): Error transferring file: Connection timed out 

I reran this build and it finished successfully

--
Matthias

Back to the top