[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
[
List Home]
|
Re: [egit-dev] New dependency from org.eclipse.egit.ui to MyLyn
|
In case Mylyn is part of your target platform, PDE will not bother you.
And Gunnar is right, this change makes sense to be in the egit.ui bundle instead of being tight to the Mylyn bundle as it does not really depend on Mylyn.
For the case that you don't have Mylyn in the target platform, we could change the PDE builder prefs to warn/ignore missing extension points. Any thoughts?
Benny
On Fri, Jul 8, 2011 at 1:03 PM, Gunnar Wagenknecht
<gunnar@xxxxxxxxxxxxxxx> wrote:
Am 08.07.2011 10:44, schrieb Baumgart, Jens:
> Are we sure about this new dependency? Should plain EGit depend on MyLyn?
I think "it depends". The change set only touches plugin.xml. It adds
metadata to the extension registry that is read by Mylyn (if installed).
The plugin works even if Mylyn is not installed. Technically, no
dependency is necessary.
I assume that the workspace still compiles (in terms of Java compile).
The error you get should be from the PDE builder which complains about
the unknown/missing extension point.
Having the metadata in place is good in case Mylyn is installed but the
Mylyn EGit extension is not installed (yet). It does not harm in the
other case. It's confusing, though.
-Gunnar
--
Gunnar Wagenknecht
gunnar@xxxxxxxxxxxxxxx
http://wagenknecht.org/
_______________________________________________
egit-dev mailing list
egit-dev@xxxxxxxxxxx
https://dev.eclipse.org/mailman/listinfo/egit-dev
--
Benjamin Muskalla
Tasktop Technologies
http://tasktop.com
