Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [egit-dev] Whitespace conventions

tisdag 27 oktober 2009 20:06:46 skrev  Ferry Huberts:
> Shawn O. Pearce wrote:
> > Alex Blewitt <alex.blewitt@xxxxxxxxx> wrote:
> >> On Thu, Oct 22, 2009 at 8:39 PM, Matthias Sohn
> >>
> >> <matthias.sohn@xxxxxxxxxxxxxx> wrote:
> >>> I remember Shawn having a quite strong opinion against such changes,
> >>> see his comments on Mykola's proposed patch
> >>> http://egit.eclipse.org/r/#change,70. He seems currently not to be near
> >>> some computer hence I propose we wait until he's back to give him a
> >>> chance to comment on your proposal.
> >>
> >> Seems reasonable to wait. I think the fears are unfounded,
> >> particularly given the analysis and diff, but I fail to see how not
> >> doing it is going to help the project.
> >>
> >> Let's wait for his thoughts when he returns.
> >
> > I'm back.  Given Alex's analysis in the original message that
> > started this thread, I think I've changed my mind and am willing
> > to apply this now.
>
> how do these changes interact with eclipse?
>
> last week I tried to edit some files and format them and immediately got
> whitespace changes (while I think I setup the formatter correctly)?

The save action will remove them again. It's a bit annoying though.

-- robin



Back to the top