Skip to main content

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ee4j-pmc] Github / Glassfish 5.1.0 branches

You will probably need to ask Anand (https://projects.eclipse.org/projects/ee4j.grizzly/who) about the status of the grizzly patch you are referring to and when that could be incorporated into EE4j Grizzly - you can probably reach him over on https://accounts.eclipse.org/mailing-list/grizzly-dev


On Tue, 5 Feb 2019 at 14:54, Paul Stanley <pj.stanley@xxxxxxxxxx> wrote:
Thanks Tom.  I've been using github when comparing branches, because its quicker easier than the support that is built into most IDEs.

On the subject of missing fixes, I've noticed that the fix for the http2 memory leak (issue:22539) didn't make it in to GF 5.1.0.  Despite the fix being added to the master branch of the grizzly project back in july last year. (Grizzly/PR 2015)  This is concerning because it means that all production deployments will either need to be restarted every few hours or have the HTTP2 module disabled. 

Do you know if there are any plans to do a bug fix release?

Cheers
Paul



From: ee4j-pmc-bounces@xxxxxxxxxxx <ee4j-pmc-bounces@xxxxxxxxxxx> on behalf of Tom Jenkinson <tom.jenkinson@xxxxxxxxxx>
Sent: 04 February 2019 17:25
To: EE4J PMC Discussions
Subject: Re: [ee4j-pmc] Github / Glassfish 5.1.0 branches
 
This is just an aside, and perhaps you already know this but you can use the command line git log after:
git checkout tags/5.1.0 (assuming this is the tag - which is an outstanding question as to which one it should be)
According to https://wiki.eclipse.org/JakartaEE_New_Infra_Release_Job the tag would be 5.1.0-RELEASE but that tag doesn't have the commit you reference before and is from the end of December so probably not the one you are looking for.

On Mon, 4 Feb 2019 at 13:05, Paul Stanley <pj.stanley@xxxxxxxxxx> wrote:
Hello.

I’m looking at the Glassfish 5.1.0 release and trying to understand what changes actually made it in.  It appears that the glassfish-bot created two branches (5.1.0 and 5.1.0-RELEASE) in the main glassfish repository, but neither of these contain the source code that was actually released.  This is proven because both branches are missing PR 22715, but the change made it into the release.  As well as the branches the release-bot also tagged the source code with same names as those branches above.  However due to the way that the github.com works, it is not possible to view the tags when they have the same name as a branch.

Is it possible to delete the 5.1.0 branches from the main repository as they are misleading and will lead to future maintenance issues.

Cheers
Paul
_______________________________________________
ee4j-pmc mailing list
ee4j-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/ee4j-pmc
_______________________________________________
ee4j-pmc mailing list
ee4j-pmc@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/ee4j-pmc

Back to the top