Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ee4j-build] Problem releasing XML Registries (JAXR) 
On 9/6/19 11:00 AM, Lukas Jungmann wrote:
on a side note: make sure the 'spec' artifact won't make it to central; AFAIK it is also not allowed to appear on staging repo...
If the spec artifact isn't meant to be deployed then the choice of artifactId doesn't matter much. This also means that there is no need for a parent since only the API should be deployed ; if the top level pom only aggregates the build then its artifactId doesn't matter much as well. 

thanks,
--lukas

On 9/6/19 7:57 PM, Romain Grecourt wrote:

On 9/6/19 10:08 AM, Jim Krueger wrote:
I have created Sonatype issue https://issues.sonatype.org/browse/OSSRH-51386 for this problem.  We need to understand why the parent pom's for management and jaxr were not deployed.  Beyond that, the partial release that was performed yesterday has left both projects in a state where maven central may need to be cleaned up before any new attempts can be made.
I'm not sure how the release jobs are setup, but you had a staging repository with a description that mentioned the parent pom:
[INFO] jakartaxmlregistry-1005 CLOSED jakarta.xml.registry:xml.registry-api-parent:1.0.10
This feels like it's not a side effect but rather something done explicitly by the release script. 

--
Regarding the artifactId naming, I find the use of the same prefix in the artifactIds more consistent, i.e "jakarta.xml.registry-parent" and "jakarta.xml.registry-spec".
I've looked at other similar repositories under the eclipse-ee4j organization: 
  - https://github.com/eclipse-ee4j/jms-api
  - https://github.com/eclipse-ee4j/jsonb-api
  - https://github.com/eclipse-ee4j/jpa-api
  - https://github.com/eclipse-ee4j/security-api
  - https://github.com/eclipse-ee4j/websocket-api
  - https://github.com/eclipse-ee4j/ejb-api
  - https://github.com/eclipse-ee4j/common-annotations-api
  - https://github.com/eclipse-ee4j/jaxb-api

There seems to be two patterns here:
1) JAXR and co: single Maven build with a parent pom and only the api artifactId starts with the package name 2) JPA, JAXB: the spec and api modules are standalone and can be deployed separately, there may be a top level pom (not a parent) to aggregate the Maven build
JSONB is a little odd, it follows #2 except that the spec artifactId is "jsonb-spec".
Note that it may be already too late to change what's been deployed already, Sonatype isn't very keen on pruning stuff out of Maven Central. Also the GAV matters mostly for the API artifacts since it's visible to end-users, the spec and parent pom if any are not very visible so consistency is not super important for these.
On Fri, Sep 6, 2019 at 9:30 AM Jim Krueger <jckofbyron@xxxxxxxxx <mailto:jckofbyron@xxxxxxxxx>> wrote: 

    I agree Kevin.  The question is, should the pom.xml be changed to
        <parent>
    <groupId>jakarta.xml.registry</groupId>
    <artifactId>registry-api-parent</artifactId>
            <version>1.0.10-SNAPSHOT</version>
        </parent>
    (which matches what Dmitry did in JAX-RPC)
    or change it to:
        <parent>
    <groupId>jakarta.xml.registry</groupId>
<artifactId>jakarta.xml.registry-api-parent</artifactId>
            <version>1.0.10-SNAPSHOT</version>
        </parent>
    (which matches what is in mvnrepository.com
    <http://mvnrepository.com>)

    And then the question is will modifying an re-building affect the
    approvals for JAXR that have already been granted?

    On Fri, Sep 6, 2019 at 9:05 AM Kevin Sutter <sutter@xxxxxxxxxx
    <mailto:sutter@xxxxxxxxxx>> wrote:

        Jim,
        Something in our pom configuration for jaxr is preventing the
        parent pom from deploying.  So, either we need to figure out
        how to properly deploy the parent pom:

        <parent>
<groupId>jakarta.xml.registry</groupId>
<artifactId>xml.registry-api-parent</artifactId>
            <version>1.0.10-SNAPSHOT</version>
        </parent>
        Or, we change the parent pom reference to something that exists: 

https://repo.maven.apache.org/maven2/org/eclipse/ee4j/project/1.0.5/

        I'd prefer that we go the first option.  It could be something
        simple in the pom that is preventing the parent from deploying.

        ---------------------------------------------------
        Kevin Sutter
        STSM, MicroProfile and Jakarta EE architect
        e-mail: sutter@xxxxxxxxxx <mailto:sutter@xxxxxxxxxx>            Twitter:  @kwsutter 
        phone: tl-553-3620 (office), 507-253-3620 (office)
        LinkedIn: https://www.linkedin.com/in/kevinwsutter



        From: Jim Krueger <jckofbyron@xxxxxxxxx
        <mailto:jckofbyron@xxxxxxxxx>>
        To: EE4J build and releng discussions <ee4j-build@xxxxxxxxxxx
        <mailto:ee4j-build@xxxxxxxxxxx>>, romain.grecourt@xxxxxxxxxx
        <mailto:romain.grecourt@xxxxxxxxxx>, Dmitry Kornilov
        <dmitry.kornilov@xxxxxxxxxx <mailto:dmitry.kornilov@xxxxxxxxxx>> 
        Date: 09/06/2019 08:35 AM
        Subject: [EXTERNAL] Re: [ee4j-build] Problem releasing XML
        Registries (JAXR)
        Sent by: ee4j-build-bounces@xxxxxxxxxxx
        <mailto:ee4j-build-bounces@xxxxxxxxxxx>
------------------------------------------------------------------------
        Thanks Romain,  however I'm confused on how to proceed with this. 

        I am using jax-rpc-api as a model (which was successfully
        released by Dmitry).   In JAX-RPC the parent is
        <artifactId>rpc-api-parent</artifactId>, whereas the
        artifactId for JAXR is
<artifactId>xml.registry-api-parent</artifactId>.

        Are you saying that both of these are wrong?  Should the
        artifactId for JAX-RPC be "jakarta.xml.rpc-api-parent" and
        JAXR be "jakarta.xml.registry-api-parent"?

        Or maybe I should just remove the "xml." prefix from the
        artifactId for JAXR to match what JAX-RPC is doing? Is there a
        good place to verify these artifactId's?

        Thanks.

        On Thu, Sep 5, 2019 at 5:39 PM Romain Grecourt
        <_romain.grecourt@oracle.com_
        <mailto:romain.grecourt@xxxxxxxxxx>> wrote:
        Seems like the nexus maven plugin choked itself ;)

        Looking at Maven Central, I see
        jakarata.xml.registry:jakarta.xml.registry-api:1.0.10.
        However its pom references a parent that doesn't exist:
_http://repo1.maven.org/maven2/jakarta/xml/registry/jakarta.xml.registry-api/1.0.10/jakarta.xml.registry-api-1.0.10.pom_

        Unless the parent pom is being synced from OSSRH to Maven
        Central, the API artifact is not resolvable.
        I suggest you wait for a couple hours and respin the release
        of the parent pom.

        --

        Side notes.

        I don't understand why the parent pom is deployed separately.
        Also the parent pom and spec artifactId don't use the
        "jakarta." prefix, it feels inconsistent.

        On 9/5/19 3:15 PM, Jim Krueger wrote:
        Hi,
        I've hit a problem releasing the XML Registries (JAXR) project
        running the recommended script
_https://jenkins.eclipse.org/jakartaee-stable/job/nexus-release-by-project/configure_

        I first ran the job to see the list of id's (mvnq
        ${NEXUS_PLUGIN_PARAMS} ${NEXUS_PLUGIN}:rc-list)  and saw the
        following output:
_https://jenkins.eclipse.org/jakartaee-stable/job/nexus-release-by-project/4/console_

        [INFO] jakartaenterprisedeploy-1011 CLOSED   Close staging
        repository automatically for uploaded bundle.
        [INFO] jakartaxmlregistry-1005 CLOSED
        jakarta.xml.registry:xml.registry-api-parent:1.0.10


        So I then used the given id (jakartaxmlregistry-1005) and
        attempted the release job
        (mvnq -DstagingRepositoryId="$ID" ${NEXUS_PLUGIN_PARAMS}
        ${NEXUS_PLUGIN}:rc-release)

        but this job failed:
_https://jenkins.eclipse.org/jakartaee-stable/job/nexus-release-by-project/5/console_

        [INFO] RC-Releasing staging repository with
        IDs=[jakartaxmlregistry-1005]

        Waiting for operation to complete...
        ....

        [INFO]
------------------------------------------------------------------------ 
        [INFO] BUILD FAILURE
        [INFO]
------------------------------------------------------------------------ 
        [INFO] Total time:  29.472 s
        [INFO] Finished at: 2019-09-05T21:34:44Z
        [INFO]
------------------------------------------------------------------------ 
        [ERROR] Failed to execute goal
org.sonatype.plugins:nexus-staging-maven-plugin:1.6.7:rc-release
        (default-cli) on project standalone-pom: Execution default-cli
        of goal
org.sonatype.plugins:nexus-staging-maven-plugin:1.6.7:rc-release
        failed: A message body reader for Java class
com.sonatype.nexus.staging.api.dto.StagingProfileRepositoryDTO, and
        Java type class
com.sonatype.nexus.staging.api.dto.StagingProfileRepositoryDTO, and
        MIME media type text/html was not found -> [Help 1]
        [ERROR]
        [ERROR] To see the full stack trace of the errors, re-run
        Maven with the -e switch.
        [ERROR] Re-run Maven using the -X switch to enable full debug
        logging.


        If I run the list job again I no longer see jakartaxmlregistry
        in the list so I assume I cannot re-run the release job.


        Has anyone seen this failure or know how to resolve?


        Thanks



        _______________________________________________
        ee4j-build mailing list
        _ee4j-build@eclipse.org_ <mailto:ee4j-build@xxxxxxxxxxx>
        To change your delivery options, retrieve your password, or
        unsubscribe from this list, visit
        _https://www.eclipse.org/mailman/listinfo/ee4j-build_

        _______________________________________________
        ee4j-build mailing list_
        __ee4j-build@eclipse.org_ <mailto:ee4j-build@xxxxxxxxxxx>
        To change your delivery options, retrieve your password, or
        unsubscribe from this list, visit_
__https://www.eclipse.org/mailman/listinfo/ee4j-build________________________________________________
        ee4j-build mailing list
        ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
        To change your delivery options, retrieve your password, or
        unsubscribe from this list, visit
        https://www.eclipse.org/mailman/listinfo/ee4j-build


        _______________________________________________
        ee4j-build mailing list
        ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
        To change your delivery options, retrieve your password, or
        unsubscribe from this list, visit
        https://www.eclipse.org/mailman/listinfo/ee4j-build


_______________________________________________
ee4j-build mailing list
ee4j-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/ee4j-build



_______________________________________________
ee4j-build mailing list
ee4j-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/ee4j-build


_______________________________________________
ee4j-build mailing list
ee4j-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit 
https://www.eclipse.org/mailman/listinfo/ee4j-build

Back to the top