Skip to main content
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [List Home]
Re: [ee4j-build] Fwd: [eclipse-ee4j/jta-api] Jakarta release has wrong OSGi Bundle-SymbolicName (#27)
Thanks Lukas, that makes sense.


But what I am not sure of is if my PR is valid to do. Before you mentioned before that we weren't meant to be changing the extension.name (https://github.com/eclipse-ee4j/jta-api/pull/7#discussion_r220259536) but that seems to be necessary to make this work?

Also, I had to disable the spec-plugin to make this work which seems unfortunate too. I looked at a few of the repos in this list https://github.com/eclipse-ee4j/jaxrs-api/issues/709#issuecomment-445177257 and they don't seem to be using spec (or don't have check-module goal enabled in it).

Also note that the PR changes the manifest in the following ways from my view of it:
Bundle-SymbolicName: jakarta.transaction-api
Bundle-Name: jakarta.transaction API
Extension-Name: jakarta.transaction

Is that what we are trying to do?

On Fri, 7 Dec 2018 at 11:04, Lukas Jungmann <lukas.jungmann@xxxxxxxxxx> wrote:
On 12/7/18 11:43 AM, Tom Jenkinson wrote:
>
>
> On Thu, 6 Dec 2018 at 18:58, Bill Shannon <bill.shannon@xxxxxxxxxx
> <mailto:bill.shannon@xxxxxxxxxx>> wrote:
>
>     I don't think that bug is critical for this release, but if you can
>     release another dot-dot version of the API to fix it that would be
>     great.
>
>
> Do we need to go through ipzilla and start a new release review request
> for this? I guess so.

No, release review is typically not needed for micro updates (aka
service releases), see
https://wiki.eclipse.org/Development_Resources/HOWTO/Release_Reviews#Reviews_are_Not_Required_for_Service_Releases

thanks,
--lukas

>
>
>     Hopefully the spec-version-maven-plugin can catch these errors, are
>     you using it?
>
>
> I am using that plugin:
> https://github.com/eclipse-ee4j/jta-api/blob/master/pom.xml#L119
>
> It did not complain from what I could see, perhaps there is a later
> version of the plugin. I will look during the fix of the issue.
>
>
>     Others will have to answer about the current TCK process...
>
>     Tom Jenkinson wrote on 12/6/18 6:56 AM:
>>     Hi,
>>
>>     A user from the JTA community raised the topic of an OSGi bundle
>>     symbolic name being incorrect in the Jakarta EE JTA API release.
>>
>>     Is this something I should be looking to change? I don't think it
>>     was specifically raised as something to address yet?
>>
>>     If it is a change that must be made prior to GlassFish 5.1, is the
>>     process to request a TCK run still to tag @anajosep as I did
>>     previously [1]
>>
>>     Thanks,
>>     Tom
>>
>>     [1]
>>     https://github.com/eclipse-ee4j/jta-api/pull/20#issuecomment-427812952
>>
>>
>>     ---------- Forwarded message ---------
>>     From: *rfelcman* <notifications@xxxxxxxxxx
>>     <mailto:notifications@xxxxxxxxxx>>
>>     Date: Thu, 6 Dec 2018 at 14:48
>>     Subject: [eclipse-ee4j/jta-api] Jakarta release has wrong OSGi
>>     Bundle-SymbolicName (#27)
>>     To: eclipse-ee4j/jta-api <jta-api@xxxxxxxxxxxxxxxxxx
>>     <mailto:jta-api@xxxxxxxxxxxxxxxxxx>>
>>     Cc: Subscribed <subscribed@xxxxxxxxxxxxxxxxxx
>>     <mailto:subscribed@xxxxxxxxxxxxxxxxxx>>
>>
>>
>>     Jakarta release of this API has wrong value of OSGi
>>     Bundle-SymbolicName in MANIFEST.MF.
>>     Current value is /javax.transaction-api/ but expected value could
>>     be /jakarta.transaction-api/ .
>>
>>     —
>>     You are receiving this because you are subscribed to this thread.
>>     Reply to this email directly, view it on GitHub
>>     <https://github.com/eclipse-ee4j/jta-api/issues/27>, or mute the
>>     thread
>>     <https://github.com/notifications/unsubscribe-auth/AATXnNVd__PKbo2_pPRfJCNAhyZwxuPyks5u2S4rgaJpZM4ZGppR>.
>>
>>
>>     _______________________________________________
>>     ee4j-build mailing list
>>     ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
>>     To change your delivery options, retrieve your password, or unsubscribe from this list, visit
>>     https://www.eclipse.org/mailman/listinfo/ee4j-build
>
>
>
> _______________________________________________
> ee4j-build mailing list
> ee4j-build@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/ee4j-build
>
_______________________________________________
ee4j-build mailing list
ee4j-build@xxxxxxxxxxx
To change your delivery options, retrieve your password, or unsubscribe from this list, visit
https://www.eclipse.org/mailman/listinfo/ee4j-build

Back to the top