Re: [ee4j-build] EE4J Parent pom.xml update

[Mark Thomas <markt@xxxxxxxxxx>]

On 02/11/2018 17:22, Romain Grécourt wrote:
> On Fri, Nov 2, 2018 at 10:08 AM arjan tijms <arjan.tijms@xxxxxxxxx
> <mailto:arjan.tijms@xxxxxxxxx>> wrote:
> 
>     Hi,
> 
>     On Fri, Nov 2, 2018 at 5:48 PM Romain Grécourt
>     <romain.grecourt@xxxxxxxxx <mailto:romain.grecourt@xxxxxxxxx>> wrote:
> 
>         The outcome of that thread was a wiki page that Bill wrote to
>         gather all the configuration required:
>         https://wiki.eclipse.org/EE4J_Maven_Publishing
> 
>         Yes, every project doing maven deployment will need to use that
>         plugin so it makes sense to put that configuration in the ee4j
>         parent pom.
> 
> 
>     That by itself sounds good to me, but I do feel reluctant updating
>     all the projects I'm responsible for and having to beg and plea for
>     PRs to them to be merged, and then when the parent pom has been
>     updated with exactly that, remove it again from the poms and do the
>     full round of begging en pleading again.
> 
> 
> I'm not sure I know a good way to work around this :(.

Simple. Ditch the requirement that PRs from committers need to be
reviewed by another committer before it is merged. Changes can be
reviewed just as easily after they have been merged as before.

There is no good reason for this restriction. It is adding a huge amount
of delay, overhead and frustration for every EE4J project I am involved
in. In the unlikely event something is committed in error it can simply
be reverted.

The benefits to the projects of removing this restriction far outweigh
any cost there might be in terms of time spent reverting erroneous
changes. Tasks that have taken me weeks to complete could have been
completed in a few hours.

Mark

>  
> 
> 
>     [small rant]
>     It might be helpful if the branch protected for EE4J branches, at
>     least for selected people working on the jobs, is temporarily
>     removed. I'm not sure how everyone else feels about this, but I'm
>     not particularly happy with all the begging that needs to be done to
>     get a PR merged. Dmitry for instance has been an extremely good help
>     here, but I do feel somewhat troubled sending him mails all the
>     time. Other committers in the projects likely don't even see the PR
>     review requests. I often ask a review from the full group of 15
>     people (the max on GitHub), and just nobody responds.
> 
>     Okay, enough ranting ;)
> 
>     What would you suggest here? Update the poms first, or wait for that
>     config to become available in the parent pom?
> 
> 
> When I submitted a PR to the parent pom, it was released and available a
> few hours after being merged by Dmitry.
> If you are not in a hurry, I'd suggest to submit the PR for the parent
> pom and wait for the new version to be available.
> 
> Romain
>  
> 
> 
>     Thanks!
> 
>     Kind regards,
>     Arjan
> 
> 
> 
> 
> 
> 
>      
> 
> 
>         On Fri, Nov 2, 2018 at 8:18 AM arjan tijms
>         <arjan.tijms@xxxxxxxxx <mailto:arjan.tijms@xxxxxxxxx>> wrote:
> 
>             Hi,
> 
>             This looks similar but not exactly the same as what Stuart
>             found necessary to do for the Servlet API project:
> 
>             https://github.com/eclipse-ee4j/servlet-api/pull/220/files
> 
>             The Servlet API project is not different from 90% of the
>             other EE4J projects out there, so if Stuart found those
>             changes necessary for Servlet to actually stage, and have
>             that stage accessible, then shouldn't that be in the parent pom?
> 
>             Compare the result of Stuart staging:
> 
>             https://oss.sonatype.org/content/groups/staging/jakarta/servlet/jakarta.servlet-api/
> 
>             vs e.g. my co-worker Mark staging using the oss-release
>             profile, but without the changes that Stuart did:
> 
>             https://oss.sonatype.org/service/local/staging/deploy/maven2/jakarta/enterprise/concurrent/jakarta.enterprise.concurrent-api/
> 
>             In Mark's staging you get a:
> 
>             ---
>             Access Denied
> 
>             Please login before attempting further requests.
>             ---
> 
>             Kind regards,
>             Arjan
> 
> 
> 
> 
>             On Thu, Nov 1, 2018 at 4:05 PM Tomas Kraus
>             <tomas.kraus@xxxxxxxxxx <mailto:tomas.kraus@xxxxxxxxxx>> wrote:
> 
>                 Hi all
> 
>                 Romain fixed typo in staging profile in parent pom. It's
>                 released as 1.0.4 version so please update your poms.
> 
>                 "staging" profile will get usefull when working with new
>                 not yet released artifacts (e.g. jakarta.activation-api
>                 1.2.1).
> 
> 
>                 Tomas
> 
>                 _______________________________________________
>                 ee4j-build mailing list
>                 ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
>                 To change your delivery options, retrieve your password,
>                 or unsubscribe from this list, visit
>                 https://www.eclipse.org/mailman/listinfo/ee4j-build
> 
>             _______________________________________________
>             ee4j-build mailing list
>             ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
>             To change your delivery options, retrieve your password, or
>             unsubscribe from this list, visit
>             https://www.eclipse.org/mailman/listinfo/ee4j-build
> 
>         _______________________________________________
>         ee4j-build mailing list
>         ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
>         To change your delivery options, retrieve your password, or
>         unsubscribe from this list, visit
>         https://www.eclipse.org/mailman/listinfo/ee4j-build
> 
>     _______________________________________________
>     ee4j-build mailing list
>     ee4j-build@xxxxxxxxxxx <mailto:ee4j-build@xxxxxxxxxxx>
>     To change your delivery options, retrieve your password, or
>     unsubscribe from this list, visit
>     https://www.eclipse.org/mailman/listinfo/ee4j-build
> 
> 
> _______________________________________________
> ee4j-build mailing list
> ee4j-build@xxxxxxxxxxx
> To change your delivery options, retrieve your password, or unsubscribe from this list, visit
> https://www.eclipse.org/mailman/listinfo/ee4j-build
>